Bug 1256498 - Disable C4838 to unblock compilation on VS2015; r?jrmuizel draft
authorGregory Szorc <gps@mozilla.com>
Mon, 14 Mar 2016 17:31:03 -0700
changeset 340086 b7bee94570c375a201eb43e29fa255b69144cfde
parent 340085 4351078c1300834bee15049c304b04bbe14aeda0
child 340087 597b4cbe606ba441a86155276033c45080babe04
push id12906
push usergszorc@mozilla.com
push dateTue, 15 Mar 2016 00:31:26 +0000
reviewersjrmuizel
bugs1256498
milestone48.0a1
Bug 1256498 - Disable C4838 to unblock compilation on VS2015; r?jrmuizel As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. MozReview-Commit-ID: 6uMZ2d1ZBji
gfx/layers/moz.build
--- a/gfx/layers/moz.build
+++ b/gfx/layers/moz.build
@@ -450,8 +450,13 @@ if CONFIG['ENABLE_TESTS']:
 
 MOCHITEST_MANIFESTS += ['apz/test/mochitest/mochitest.ini']
 MOCHITEST_CHROME_MANIFESTS += ['apz/test/mochitest/chrome.ini']
 
 CXXFLAGS += CONFIG['MOZ_CAIRO_CFLAGS']
 CXXFLAGS += CONFIG['TK_CFLAGS']
 
 LOCAL_INCLUDES += CONFIG['SKIA_INCLUDES']
+
+if CONFIG['_MSC_VER']:
+    # This is intended as a temporary hack to support building with VS2015.
+    # conversion from 'int32_t' to 'float' requires a narrowing conversion
+    CXXFLAGS += ['-wd4838']