Bug 1255686 - Pass --authentication-file to tooltool; r?rail draft
authorGregory Szorc <gps@mozilla.com>
Mon, 14 Mar 2016 15:30:52 -0700
changeset 6662 f1d14ab67f544f966b5e48a26433b1d0c2715887
parent 6660 d239061cf51513d8c6c82773d3e24917e8cea89b
push id35
push usergszorc@mozilla.com
push dateMon, 14 Mar 2016 22:31:56 +0000
reviewersrail
bugs1255686
Bug 1255686 - Pass --authentication-file to tooltool; r?rail The previous attempt at this was completely wrong yet somehow didn't bust automation. We were attempted to use hgtool_args but used httool_args due to a typo. In this patch, we simply pass --authentication-file into tooltool directly instead of grabbing the value from CLI arguments. This is less configurable, but doesn't require buildbotcustom integration. MozReview-Commit-ID: JC1pqBULWkT
scripts/spidermonkey_builds/spidermonkey.sh
--- a/scripts/spidermonkey_builds/spidermonkey.sh
+++ b/scripts/spidermonkey_builds/spidermonkey.sh
@@ -38,21 +38,16 @@ while [ $# -gt 0 ]; do
         --ttserver)
             # Note that this script (and tooltool_wrapper.sh, and tooltool.py)
             # only accepts a single tooltool server, so all but the last will
             # be ignored.
             shift
             TT_SERVER="$1"
             shift
             ;;
-        --ttauthfile)
-            shift
-            httool_args+=(--authentication-file "$1")
-            shift
-            ;;
         -r|--rev)
             shift
             hgtool_args+=(--clone-by-revision -r "$1")
             shift
             ;;
         --dep)
             shift
             noclean=1
@@ -136,19 +131,19 @@ else
       TT_WRAPPER=$SCRIPTS_DIR/scripts/tooltool/tooltool_wrapper.sh
       manifest_platform=${platform%-debug}
       if [ "$manifest_platform" = linux ]; then
           manifest_platform=linux32
       fi
       TT_MANIFEST=$SOURCE/browser/config/tooltool-manifests/$manifest_platform/releng.manifest
       TT_BOOTSTRAP=setup.sh
       if [ "$OSTYPE" = "msys" ]; then
-          $TT_WRAPPER $TT_MANIFEST $TT_SERVER $TT_BOOTSTRAP 'c:\mozilla-build\python27\python.exe' C:/mozilla-build/tooltool.py
+          $TT_WRAPPER $TT_MANIFEST $TT_SERVER $TT_BOOTSTRAP 'c:\mozilla-build\python27\python.exe' C:/mozilla-build/tooltool.py --authentication-file c:/builds/relengapi.tok
       else
-          $TT_WRAPPER $TT_MANIFEST $TT_SERVER $TT_BOOTSTRAP /builds/tooltool.py
+          $TT_WRAPPER $TT_MANIFEST $TT_SERVER $TT_BOOTSTRAP /builds/tooltool.py --authentication-file /builds/relengapi.tok
       fi
 
       if [[ "$OSTYPE" == darwin* ]]; then
           export CC=$(pwd)/clang/bin/clang
           export CXX=$(pwd)/clang/bin/clang++
       elif [ "$OSTYPE" = "linux-gnu" ]; then
           export CC=$(pwd)/gcc/bin/gcc
           export CXX=$(pwd)/gcc/bin/g++