Bug 1130979 - Added ANON constant to By class and changed hard-coded values in test file; r?maja_zf draft
authorKim Brown <kbmoz1515@gmail.com>
Sat, 12 Mar 2016 13:32:46 -0500
changeset 341231 81037803e63f2b6214f69474b20fe0331b8cd537
parent 341230 e22fa980b30b7037b66614b8f171a0cff16eee7c
child 516368 c53d5fbaf8903032dcc2f0b6cddcac17f1d794f2
push id13173
push userbmo:kbmoz1515@gmail.com
push dateWed, 16 Mar 2016 19:49:36 +0000
reviewersmaja_zf
bugs1130979
milestone48.0a1
Bug 1130979 - Added ANON constant to By class and changed hard-coded values in test file; r?maja_zf MozReview-Commit-ID: AOsb6l9UpVR
testing/marionette/client/marionette_driver/by.py
testing/marionette/harness/marionette/tests/unit/test_anonymous_content.py
--- a/testing/marionette/client/marionette_driver/by.py
+++ b/testing/marionette/client/marionette_driver/by.py
@@ -19,8 +19,9 @@ class By(object):
     XPATH = "xpath"
     LINK_TEXT = "link text"
     PARTIAL_LINK_TEXT = "partial link text"
     NAME = "name"
     TAG_NAME = "tag name"
     CLASS_NAME = "class name"
     CSS_SELECTOR = "css selector"
     ANON_ATTRIBUTE = "anon attribute"
+    ANON = "anon"
--- a/testing/marionette/harness/marionette/tests/unit/test_anonymous_content.py
+++ b/testing/marionette/harness/marionette/tests/unit/test_anonymous_content.py
@@ -51,15 +51,15 @@ class TestAnonymousContent(MarionetteTes
         self.assertEquals(1, len(el.find_elements(By.ANON_ATTRIBUTE, {"anonid": "buttons"})))
 
         with self.assertRaises(NoSuchElementException):
             el.find_element(By.ANON_ATTRIBUTE, {"anonid": "nonexistent"})
         self.assertEquals([], el.find_elements(By.ANON_ATTRIBUTE, {"anonid": "nonexistent"}))
 
     def test_find_anonymous_children(self):
         el = Wait(self.marionette).until(element_present(By.ID, "dia"))
-        self.assertEquals(HTMLElement, type(el.find_element("anon", None)))
-        self.assertEquals(2, len(el.find_elements("anon", None)))
+        self.assertEquals(HTMLElement, type(el.find_element(By.ANON, None)))
+        self.assertEquals(2, len(el.find_elements(By.ANON, None)))
 
         el = self.marionette.find_element(By.ID, "framebox")
         with self.assertRaises(NoSuchElementException):
-            el.find_element("anon", None)
-        self.assertEquals([], el.find_elements("anon", None))
+            el.find_element(By.ANON, None)
+        self.assertEquals([], el.find_elements(By.ANON, None))