Bug 1255330 - Change the default value of "layout.accessiblecaret.bar.enabled" to false. draft
authorTing-Yu Lin <tlin@mozilla.com>
Thu, 10 Mar 2016 17:18:12 +0800
changeset 338968 e4915654a9c97cabb1a1fe295d741c6fecfd3795
parent 338591 af7c0cb0798f5425d5d344cbaf0ac0ecb1a72a86
child 515893 e57603d6760ee03d574ec5660bc0a19203617081
push id12621
push usertlin@mozilla.com
push dateThu, 10 Mar 2016 09:19:51 +0000
bugs1255330
milestone48.0a1
Bug 1255330 - Change the default value of "layout.accessiblecaret.bar.enabled" to false. MozReview-Commit-ID: 25pXiwtvlLH
b2g/app/b2g.js
mobile/android/app/mobile.js
modules/libpref/init/all.js
--- a/b2g/app/b2g.js
+++ b/b2g/app/b2g.js
@@ -1049,16 +1049,20 @@ pref("dom.wakelock.enabled", true);
 
 // Enable webapps add-ons
 pref("dom.apps.customization.enabled", true);
 pref("dom.apps.reviewer_paths", "/reviewers/,/extension/reviewers/");
 
 // New implementation to unify touch-caret and selection-carets.
 pref("layout.accessiblecaret.enabled", true);
 
+// Show the selection bars at the two ends of the selection highlight. Required
+// by the spec in bug 921965.
+pref("layout.accessiblecaret.bar.enabled", true);
+
 // APZ on real devices supports long tap events.
 #ifdef MOZ_WIDGET_GONK
 pref("layout.accessiblecaret.use_long_tap_injector", false);
 #endif
 
 // Enable sync and mozId with Firefox Accounts.
 pref("services.sync.fxaccounts.enabled", true);
 pref("identity.fxaccounts.enabled", true);
--- a/mobile/android/app/mobile.js
+++ b/mobile/android/app/mobile.js
@@ -908,19 +908,16 @@ pref("layout.accessiblecaret.enabled", t
 pref("layout.accessiblecaret.enabled", false);
 #endif
 
 // AccessibleCaret CSS for the Android L style assets.
 pref("layout.accessiblecaret.width", "22.0");
 pref("layout.accessiblecaret.height", "22.0");
 pref("layout.accessiblecaret.margin-left", "-11.5");
 
-// Android hides the selection bars at the two ends of the selection highlight.
-pref("layout.accessiblecaret.bar.enabled", false);
-
 // Android needs to show the caret when long tapping on an empty content.
 pref("layout.accessiblecaret.caret_shown_when_long_tapping_on_empty_content", true);
 
 // Android needs persistent carets and actionbar. Turn off the caret timeout.
 pref("layout.accessiblecaret.timeout_ms", 0);
 
 // Android generates long tap (mouse) events.
 pref("layout.accessiblecaret.use_long_tap_injector", false);
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -4957,18 +4957,18 @@ pref("snav.enabled", false);
 pref("layout.accessiblecaret.enabled", false);
 
 // CSS attributes of the AccessibleCaret in CSS pixels.
 pref("layout.accessiblecaret.width", "34.0");
 pref("layout.accessiblecaret.height", "36.0");
 pref("layout.accessiblecaret.margin-left", "-18.5");
 pref("layout.accessiblecaret.bar.width", "2.0");
 
-// Show the selection bars at the two ends of the selection highlight.
-pref("layout.accessiblecaret.bar.enabled", true);
+// Show no selection bars at the two ends of the selection highlight.
+pref("layout.accessiblecaret.bar.enabled", false);
 
 // Show the caret when long tapping on an empty content.
 pref("layout.accessiblecaret.caret_shown_when_long_tapping_on_empty_content", false);
 
 // Timeout in milliseconds to hide the accessiblecaret under cursor mode while
 // no one touches it. Set the value to 0 to disable this feature.
 pref("layout.accessiblecaret.timeout_ms", 3000);