Bug 1255234 - Fix lint error Assert and add to error list. r=sebastian
MozReview-Commit-ID: 32Uzjjsb5MX
--- a/mobile/android/app/lint.xml
+++ b/mobile/android/app/lint.xml
@@ -46,16 +46,17 @@
<issue id="AdapterViewChildren" severity="error" />
<issue id="AddJavascriptInterface" severity="error" />
<issue id="AllowBackup" severity="error" />
<issue id="AlwaysShowAction" severity="error" />
<issue id="AndroidGradlePluginVersion" severity="error" />
<issue id="AppCompatMethod" severity="error" />
<issue id="AppIndexingError" severity="error" />
<issue id="AppIndexingWarning" severity="error" />
+ <issue id="Assert" severity="error" />
<issue id="ButtonCase" severity="error" />
<issue id="ButtonOrder" severity="error" />
<issue id="ByteOrderMark" severity="error" />
<issue id="CheckResult" severity="error" />
<issue id="Correctness" severity="error" />
<issue id="CutPasteId" severity="error" />
<issue id="DalvikOverride" severity="error" />
<issue id="DeviceAdmin" severity="error" />
--- a/mobile/android/tests/background/junit3/src/org/mozilla/gecko/background/db/TestAndroidBrowserBookmarksRepository.java
+++ b/mobile/android/tests/background/junit3/src/org/mozilla/gecko/background/db/TestAndroidBrowserBookmarksRepository.java
@@ -327,17 +327,17 @@ public class TestAndroidBrowserBookmarks
closeDataAccessor(helper);
Record record1 = BookmarkHelpers.createBookmark1();
Record record2 = BookmarkHelpers.createBookmark2();
Record record3 = BookmarkHelpers.createFolder1();
BookmarkRecord bmk3 = (BookmarkRecord) record3;
record3.guid = Utils.generateGuid();
record3.lastModified = timestampDelegate.records.get(0).lastModified + 3000;
- assert(!record0.guid.equals(record3.guid));
+ assertFalse(record0.guid.equals(record3.guid));
// Store an additional record after inserting the duplicate folder
// with new GUID. Make sure it comes back as well.
Record record4 = BookmarkHelpers.createBookmark3();
BookmarkRecord bmk4 = (BookmarkRecord) record4;
bmk4.parentID = bmk3.guid;
bmk4.parentName = bmk3.parentName;