Bug 1255127 - Decrease height of bookmark folders to match remote client item height. r=grisha
MozReview-Commit-ID: HIveNuSTuPf
--- a/mobile/android/base/resources/layout/bookmark_folder_row.xml
+++ b/mobile/android/base/resources/layout/bookmark_folder_row.xml
@@ -1,11 +1,11 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<org.mozilla.gecko.home.BookmarkFolderView xmlns:android="http://schemas.android.com/apk/res/android"
style="@style/Widget.BookmarkFolderView"
android:layout_width="match_parent"
- android:layout_height="@dimen/page_row_height"
- android:minHeight="@dimen/page_row_height"
+ android:layout_height="@dimen/page_group_height"
+ android:minHeight="@dimen/page_group_height"
android:gravity="center_vertical"/>
--- a/mobile/android/base/resources/layout/home_history_range_item.xml
+++ b/mobile/android/base/resources/layout/home_history_range_item.xml
@@ -1,17 +1,17 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:background="@color/about_page_header_grey"
android:layout_width="match_parent"
- android:layout_height="@dimen/page_row_height">
+ android:layout_height="@dimen/home_header_item_height">
<TextView android:id="@+id/range_title"
style="@style/Widget.TwoLinePageRow.Title"
android:paddingLeft="15dp"
android:paddingRight="15dp"
android:layout_gravity="center_vertical"
android:layout_width="match_parent"
android:layout_height="wrap_content"/>
--- a/mobile/android/base/resources/layout/home_remote_tabs_group.xml
+++ b/mobile/android/base/resources/layout/home_remote_tabs_group.xml
@@ -6,18 +6,18 @@
-->
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
xmlns:gecko="http://schemas.android.com/apk/res-auto"
style="@style/Widget.RemoteTabsClientView"
android:gravity="center_vertical"
android:layout_width="match_parent"
- android:layout_height="@dimen/page_group_height"
- android:minHeight="@dimen/page_group_height">
+ android:layout_height="@dimen/home_header_item_height"
+ android:minHeight="@dimen/home_header_item_height">
<ImageView
android:id="@+id/device_type"
android:layout_width="50dp"
android:layout_height="50dp"
android:layout_marginLeft="5dp"
android:layout_gravity="center_vertical"
android:scaleType="center"
--- a/mobile/android/base/resources/values-land/dimens.xml
+++ b/mobile/android/base/resources/values-land/dimens.xml
@@ -2,12 +2,10 @@
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<resources>
<!-- Remote Tabs static view top padding. Less in landscape on phones. -->
<dimen name="home_remote_tabs_top_padding">16dp</dimen>
- <dimen name="page_group_height">64dp</dimen>
-
<dimen name="tab_panel_grid_padding">48dp</dimen>
</resources>
--- a/mobile/android/base/resources/values-large-land-v11/dimens.xml
+++ b/mobile/android/base/resources/values-large-land-v11/dimens.xml
@@ -2,10 +2,11 @@
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<resources>
<!-- Remote Tabs static view top padding. Less in landscape on phones. -->
<dimen name="home_remote_tabs_top_padding">48dp</dimen>
+ <dimen name="home_header_item_height">64dp</dimen>
</resources>
--- a/mobile/android/base/resources/values/dimens.xml
+++ b/mobile/android/base/resources/values/dimens.xml
@@ -81,16 +81,17 @@
<dimen name="page_row_edge_padding">16dp</dimen>
<!-- Regular page row on about:home -->
<dimen name="page_row_height">64dp</dimen>
<!-- Group/heading page row on about:home -->
<dimen name="page_group_height">56dp</dimen>
+ <dimen name="home_header_item_height">56dp</dimen>
<!-- Reading list row on about:home -->
<dimen name="reading_list_row_height">128dp</dimen>
<dimen name="reading_list_row_padding_right">10dp</dimen>
<!-- Remote Tabs static view top padding. Less in landscape on phones. -->
<dimen name="home_remote_tabs_top_padding">48dp</dimen>