Bug 1246232 - Remove "add to reading list" from link-long-press context menu r?liuche draft
authorAndrzej Hunt <ahunt@mozilla.com>
Mon, 07 Mar 2016 15:33:23 -0800
changeset 337557 e31268a6d39521539f7daac92c0844560445aa25
parent 337556 c5b71c2e6cfe14d0931560ad2cf906ab3e2a5a03
child 337563 cc7176a4f10c859e5343bc3935597ccae9ccbda4
push id12390
push userahunt@mozilla.com
push dateMon, 07 Mar 2016 23:34:38 +0000
reviewersliuche
bugs1246232
milestone47.0a1
Bug 1246232 - Remove "add to reading list" from link-long-press context menu r?liuche MozReview-Commit-ID: COprGdVgKOf
mobile/android/chrome/content/browser.js
mobile/android/locales/en-US/chrome/browser.properties
--- a/mobile/android/chrome/content/browser.js
+++ b/mobile/android/chrome/content/browser.js
@@ -695,30 +695,16 @@ var BrowserApp = {
             action: {
               label: buttonLabel,
               callback: () => { BrowserApp.selectTab(tab); },
             }
           });
         });
     }
 
-    NativeWindow.contextmenus.add(stringGetter("contextmenu.addToReadingList"),
-      NativeWindow.contextmenus.linkOpenableContext,
-      function(aTarget) {
-        UITelemetry.addEvent("action.1", "contextmenu", null, "web_reading_list");
-        UITelemetry.addEvent("save.1", "contextmenu", null, "reading_list");
-
-        let url = NativeWindow.contextmenus._getLinkURL(aTarget);
-        Messaging.sendRequestForResult({
-            type: "Reader:AddToList",
-            title: truncate(url, MAX_TITLE_LENGTH),
-            url: truncate(url, MAX_URI_LENGTH),
-        }).catch(Cu.reportError);
-      });
-
     NativeWindow.contextmenus.add(stringGetter("contextmenu.copyLink"),
       NativeWindow.contextmenus.linkCopyableContext,
       function(aTarget) {
         UITelemetry.addEvent("action.1", "contextmenu", null, "web_copy_link");
 
         let url = NativeWindow.contextmenus._getLinkURL(aTarget);
         NativeWindow.contextmenus._copyStringToDefaultClipboard(url);
       });
--- a/mobile/android/locales/en-US/chrome/browser.properties
+++ b/mobile/android/locales/en-US/chrome/browser.properties
@@ -237,17 +237,16 @@ selectionHelper.textCopied=Text copied t
 # dialog/prompt.
 casting.sendToDevice=Send to Device
 casting.mirrorTab=Mirror Tab
 casting.mirrorTabStop=Stop Mirror
 
 # Context menu
 contextmenu.openInNewTab=Open Link in New Tab
 contextmenu.openInPrivateTab=Open Link in Private Tab
-contextmenu.addToReadingList=Add to Reading List
 contextmenu.share=Share
 contextmenu.copyLink=Copy Link
 contextmenu.shareLink=Share Link
 contextmenu.bookmarkLink=Bookmark Link
 contextmenu.copyEmailAddress=Copy Email Address
 contextmenu.shareEmailAddress=Share Email Address
 contextmenu.copyPhoneNumber=Copy Phone Number
 contextmenu.sharePhoneNumber=Share Phone Number