Bug 1253466 - Don't pass --enable-threadsafe to js/src/configure draft
authorMike Hommey <mh+mozilla@glandium.org>
Fri, 04 Mar 2016 09:46:22 +0900
changeset 336646 2168d41b17c87030217f5c5190e656d6c91bafac
parent 336645 edefedca2f3e2a6c9c03c03a788826bdc1ed1227
child 336850 c99231a47b8c06e0847b506a3a68cd35dca908f2
push id12161
push userbmo:mh+mozilla@glandium.org
push dateFri, 04 Mar 2016 00:50:04 +0000
bugs1253466, 1031529
milestone47.0a1
Bug 1253466 - Don't pass --enable-threadsafe to js/src/configure The flag was removed in bug 1031529, and silently doesn't do anything. Configure.py will start barfing about unknown options, so don't pass it down.
old-configure.in
testing/mozharness/scripts/spidermonkey/build.shell
--- a/old-configure.in
+++ b/old-configure.in
@@ -9130,18 +9130,16 @@ RC=
 # Run the SpiderMonkey 'configure' script.
 dist=$MOZ_BUILD_ROOT/dist
 ac_configure_args="$_SUBDIR_CONFIG_ARGS"
 
 # --with-system-nspr will have been converted into the relevant $NSPR_CFLAGS
 # and $NSPR_LIBS.
 ac_configure_args="`echo $ac_configure_args | sed -e 's/--with-system-nspr\S* *//'`"
 
-ac_configure_args="$ac_configure_args --enable-threadsafe"
-
 if test "$_INTL_API" = no; then
     ac_configure_args="$ac_configure_args --without-intl-api"
 fi
 
 if test "$BUILD_CTYPES"; then
     # Build js-ctypes on the platforms we can.
     ac_configure_args="$ac_configure_args --enable-ctypes"
 fi
--- a/testing/mozharness/scripts/spidermonkey/build.shell
+++ b/testing/mozharness/scripts/spidermonkey/build.shell
@@ -1,9 +1,9 @@
 #!/bin/sh
 
 set -e
 set -x
 
 [ -d $ANALYZED_OBJDIR ] || mkdir $ANALYZED_OBJDIR
 cd $ANALYZED_OBJDIR
-$SOURCE/js/src/configure --enable-debug --enable-optimize --enable-stdcxx-compat --enable-ctypes --enable-exact-rooting --enable-gcgenerational --enable-threadsafe --with-system-nspr
+$SOURCE/js/src/configure --enable-debug --enable-optimize --enable-stdcxx-compat --enable-ctypes --enable-exact-rooting --enable-gcgenerational --with-system-nspr
 make -j12 -s