Bug 1250900 - Make GeckoPreferences inherit from Theme.AppCompat so that TextLayout doesn't crash r?mcomella draft
authorAndrzej Hunt <ahunt@mozilla.com>
Thu, 03 Mar 2016 16:15:45 -0800
changeset 337439 a0c03f5558b610a138788b81f8c33adeff18e362
parent 337438 6f19b1a57959a2e918096c0d66c325ec39583e91
child 515662 c7f766077b22f896d3b2422a8e7949d38c8e19f9
push id12357
push userahunt@mozilla.com
push dateMon, 07 Mar 2016 17:59:38 +0000
reviewersmcomella
bugs1250900
milestone47.0a1
Bug 1250900 - Make GeckoPreferences inherit from Theme.AppCompat so that TextLayout doesn't crash r?mcomella This results in the Preferences activity having a more material-like appearance on Android < 5. We already inherit from Gecko for v21, so it makes sense to do the same on 14 and below. MozReview-Commit-ID: GkPowooCJWv
mobile/android/base/resources/values-v11/themes.xml
mobile/android/base/resources/values/themes.xml
--- a/mobile/android/base/resources/values-v11/themes.xml
+++ b/mobile/android/base/resources/values-v11/themes.xml
@@ -19,17 +19,17 @@
         <item name="android:windowContentOverlay">@null</item>
         <item name="android:windowActionBar">false</item>
         <item name="android:windowNoTitle">true</item>
         <item name="android:windowBackground">@android:color/transparent</item>
     </style>
 
     <style name="GeckoTitleDialogBase" parent="@android:style/Theme.Holo.Light.Dialog" />
 
-    <style name="GeckoPreferencesBase" parent="@android:style/Theme.Holo.Light">
+    <style name="GeckoPreferencesBase" parent="Gecko">
         <item name="android:windowContentOverlay">@null</item>
         <item name="android:windowActionBar">true</item>
         <item name="android:windowNoTitle">false</item>
         <item name="android:actionBarStyle">@style/ActionBar.GeckoPreferences</item>
     </style>
 
     <!--
         Activity based themes for API 11+. This theme completely replaces
--- a/mobile/android/base/resources/values/themes.xml
+++ b/mobile/android/base/resources/values/themes.xml
@@ -16,17 +16,17 @@
 
     <style name="GeckoDialogBase" parent="@android:style/Theme.Dialog">
         <item name="android:windowNoTitle">true</item>
         <item name="android:windowContentOverlay">@null</item>
     </style>
 
     <style name="GeckoTitleDialogBase" parent="@android:style/Theme.Dialog" />
 
-    <style name="GeckoPreferencesBase" parent="@android:style/Theme.Light">
+    <style name="GeckoPreferencesBase" parent="Gecko">
         <item name="android:windowNoTitle">false</item>
         <item name="android:windowContentOverlay">@null</item>
     </style>
 
     <!--
         Application Theme. All customizations that are not specific
         to a particular API level can go here.
     -->