Bug 1253094, part 8 - Stop using DebugOnly for class/struct members in uriloader/. r=smaug draft
authorJonathan Watt <jwatt@jwatt.org>
Wed, 02 Mar 2016 23:56:56 +0000
changeset 336259 6b7a71837c75e12c950683016195fa9332c9625d
parent 336258 10ca8162c1f1af9e53a0d07ccb3858042e9efa7a
child 336260 6c533769d9385920308aa316b8c244baf7b7186f
push id12025
push userjwatt@jwatt.org
push dateThu, 03 Mar 2016 00:03:10 +0000
reviewerssmaug
bugs1253094
milestone47.0a1
Bug 1253094, part 8 - Stop using DebugOnly for class/struct members in uriloader/. r=smaug MozReview-Commit-ID: ID0AQq0sF4k
uriloader/exthandler/ExternalHelperAppParent.cpp
uriloader/exthandler/ExternalHelperAppParent.h
--- a/uriloader/exthandler/ExternalHelperAppParent.cpp
+++ b/uriloader/exthandler/ExternalHelperAppParent.cpp
@@ -36,17 +36,19 @@ NS_IMPL_ISUPPORTS_INHERITED(ExternalHelp
                             nsIResumableChannel,
                             nsIStreamListener)
 
 ExternalHelperAppParent::ExternalHelperAppParent(
     const OptionalURIParams& uri,
     const int64_t& aContentLength)
   : mURI(DeserializeURI(uri))
   , mPending(false)
+#ifdef DEBUG
   , mDiverted(false)
+#endif
   , mIPCClosed(false)
   , mLoadFlags(0)
   , mStatus(NS_OK)
   , mContentLength(aContentLength)
 {
 }
 
 void
@@ -154,17 +156,19 @@ ExternalHelperAppParent::RecvOnStopReque
 }
 
 bool
 ExternalHelperAppParent::RecvDivertToParentUsing(PChannelDiverterParent* diverter)
 {
   MOZ_ASSERT(diverter);
   auto p = static_cast<mozilla::net::ChannelDiverterParent*>(diverter);
   p->DivertTo(this);
+#ifdef DEBUG
   mDiverted = true;
+#endif
   Unused << p->Send__delete__(p);
   return true;
 }
 
 //
 // nsIStreamListener
 //
 
--- a/uriloader/exthandler/ExternalHelperAppParent.h
+++ b/uriloader/exthandler/ExternalHelperAppParent.h
@@ -73,17 +73,19 @@ protected:
 
   virtual void ActorDestroy(ActorDestroyReason why) override;
   void Delete();
 
 private:
   nsCOMPtr<nsIStreamListener> mListener;
   nsCOMPtr<nsIURI> mURI;
   bool mPending;
-  DebugOnly<bool> mDiverted;
+#ifdef DEBUG
+  bool mDiverted;
+#endif
   bool mIPCClosed;
   nsLoadFlags mLoadFlags;
   nsresult mStatus;
   int64_t mContentLength;
   uint32_t mContentDisposition;
   nsString mContentDispositionFilename;
   nsCString mContentDispositionHeader;
   nsCString mEntityID;