Bug 1243558 - Add nightly flags to screenshots in bookmarks feature. r=sebastian draft
authorMichael Comella <michael.l.comella@gmail.com>
Mon, 29 Feb 2016 17:22:55 -0800
changeset 335643 416f2bd05eb2dfdd9e89d687348c0e085db1dbdc
parent 335642 e88fabd64fe4f5354a5321d023ff1d2f61152c25
child 515185 5e15e9ec9e246c2eb165f1f10dd17e7caeae02f0
push id11840
push usermichael.l.comella@gmail.com
push dateTue, 01 Mar 2016 01:35:09 +0000
reviewerssebastian
bugs1243558
milestone47.0a1
Bug 1243558 - Add nightly flags to screenshots in bookmarks feature. r=sebastian MozReview-Commit-ID: F3ljXZGNKlJ
mobile/android/base/AppConstants.java.in
mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
mobile/android/base/java/org/mozilla/gecko/db/LocalBrowserDB.java
--- a/mobile/android/base/AppConstants.java.in
+++ b/mobile/android/base/AppConstants.java.in
@@ -344,9 +344,11 @@ public class AppConstants {
 //#endif
 
     public static final boolean MOZ_ANDROID_DOWNLOAD_CONTENT_SERVICE =
 //#ifdef MOZ_ANDROID_DOWNLOAD_CONTENT_SERVICE
     true;
 //#else
     false;
 //#endif
+
+    public static final boolean SCREENSHOTS_IN_BOOKMARKS_ENABLED = AppConstants.NIGHTLY_BUILD;
 }
--- a/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
+++ b/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
@@ -754,16 +754,20 @@ public class BrowserApp extends GeckoApp
 
         // Watch for screenshots while browser is in foreground.
         mScreenshotObserver.setListener(getContext(), new ScreenshotObserver.OnScreenshotListener() {
             @Override
             public void onScreenshotTaken(final String screenshotPath, final String title) {
                 // Treat screenshots as a sharing method.
                 Telemetry.sendUIEvent(TelemetryContract.Event.SHARE, TelemetryContract.Method.BUTTON, "screenshot");
 
+                if (!AppConstants.SCREENSHOTS_IN_BOOKMARKS_ENABLED) {
+                    return;
+                }
+
                 final Tab selectedTab = Tabs.getInstance().getSelectedTab();
                 if (selectedTab == null) {
                     Log.w(LOGTAG, "Selected tab is null: could not page info to store screenshot.");
                     return;
                 }
 
                 getProfile().getDB().getUrlAnnotations().insertScreenshot(
                         getContentResolver(), selectedTab.getURL(), screenshotPath);
--- a/mobile/android/base/java/org/mozilla/gecko/db/LocalBrowserDB.java
+++ b/mobile/android/base/java/org/mozilla/gecko/db/LocalBrowserDB.java
@@ -18,16 +18,17 @@ import java.util.List;
 import java.util.Locale;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
 import org.json.JSONArray;
 import org.json.JSONException;
 import org.json.JSONObject;
 import org.mozilla.gecko.AboutPages;
+import org.mozilla.gecko.AppConstants;
 import org.mozilla.gecko.annotation.RobocopTarget;
 import org.mozilla.gecko.R;
 import org.mozilla.gecko.db.BrowserContract.Bookmarks;
 import org.mozilla.gecko.db.BrowserContract.Combined;
 import org.mozilla.gecko.db.BrowserContract.ExpirePriority;
 import org.mozilla.gecko.db.BrowserContract.Favicons;
 import org.mozilla.gecko.db.BrowserContract.History;
 import org.mozilla.gecko.db.BrowserContract.SyncColumns;
@@ -792,17 +793,17 @@ public class LocalBrowserDB implements B
 
         // We always want to show mobile bookmarks in the root view.
         if (folderId == Bookmarks.FIXED_ROOT_ID) {
             folderId = getFolderIdFromGuid(cr, Bookmarks.MOBILE_FOLDER_GUID);
 
             // We'll add a fake "Desktop Bookmarks" folder to the root view if desktop
             // bookmarks exist, so that the user can still access non-mobile bookmarks.
             addDesktopFolder = desktopBookmarksExist(cr);
-            addScreenshotsFolder = true;
+            addScreenshotsFolder = AppConstants.SCREENSHOTS_IN_BOOKMARKS_ENABLED;
         } else {
             addDesktopFolder = false;
             addScreenshotsFolder = false;
         }
 
         final Cursor c;
         if (folderId == Bookmarks.FAKE_DESKTOP_FOLDER_ID) {
             // Since the "Desktop Bookmarks" folder doesn't actually exist, we