Bug 1251856 - Disable U2F in all releases (fix for 1231681) r?baku draft
authorJ.C. Jones <jjones@mozilla.com>
Mon, 29 Feb 2016 09:06:40 -0700
changeset 335477 91c51ee6a982525398e4ed0acd474156622b0739
parent 334720 918df3a0bc1c4d07299e4f66274a7da923534577
child 515133 ea572467a8c44a5ae8f56e718d166ac523630188
push id11786
push userjjones@mozilla.com
push dateMon, 29 Feb 2016 16:41:23 +0000
reviewersbaku
bugs1251856, 1231681
milestone47.0a1
Bug 1251856 - Disable U2F in all releases (fix for 1231681) r?baku * Pref off the "U2F" interface to blank out the integer constants, and * Disable U2F in all releases. MozReview-Commit-ID: 8HlkaRbg4Qh
dom/tests/mochitest/general/test_interfaces.html
dom/webidl/U2F.webidl
--- a/dom/tests/mochitest/general/test_interfaces.html
+++ b/dom/tests/mochitest/general/test_interfaces.html
@@ -1373,17 +1373,17 @@ var interfaceNamesInGlobalScope =
     {name: "TVProgram", b2g: true, permission: ["tv"]},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "TVScanningStateChangedEvent", b2g: true, permission: ["tv"]},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "TVSource", b2g: true, permission: ["tv"]},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "TVTuner", b2g: true, permission: ["tv"]},
 // IMPORTANT: Do not change this list without review from a DOM peer!
-    {name: "U2F", release: false},
+    {name: "U2F", disabled: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "UDPMessageEvent", b2g: true, permission: ["udp-socket"]},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "UDPSocket", b2g: true, permission: ["udp-socket"]},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     "UIEvent",
 // IMPORTANT: Do not change this list without review from a DOM peer!
     "UndoManager",
--- a/dom/webidl/U2F.webidl
+++ b/dom/webidl/U2F.webidl
@@ -63,16 +63,17 @@ dictionary SignResponse {
     // From Error
     ErrorCode? errorCode;
     DOMString? errorMessage;
 };
 
 callback U2FRegisterCallback = void(RegisterResponse response);
 callback U2FSignCallback = void(SignResponse response);
 
+[Pref="security.webauth.u2f"]
 interface U2F {
   // These enumerations are defined in the FIDO U2F Javascript API under the
   // interface "ErrorCode" as constant integers, and also in the U2F.cpp file.
   // Any changes to these must occur in both locations.
   const unsigned short OK = 0;
   const unsigned short OTHER_ERROR = 1;
   const unsigned short BAD_REQUEST = 2;
   const unsigned short CONFIGURATION_UNSUPPORTED = 3;