Bug 1250523 - Wait for the markup-view to be loaded in browser_markup_load_01.js; r=gl draft
authorPatrick Brosset <pbrosset@mozilla.com>
Mon, 29 Feb 2016 14:08:22 +0100
changeset 335458 d2611c127401353668a23d5b2d69499139ade081
parent 335457 76c51477853faeac91211c2adee7adfee858b276
child 515131 3f5e0c58575fa61911a983a0dd5899098283e768
push id11784
push userpbrosset@mozilla.com
push dateMon, 29 Feb 2016 15:29:21 +0000
reviewersgl
bugs1250523
milestone47.0a1
Bug 1250523 - Wait for the markup-view to be loaded in browser_markup_load_01.js; r=gl MozReview-Commit-ID: 3BSuNy1DjZk
devtools/client/inspector/markup/test/browser_markup_load_01.js
--- a/devtools/client/inspector/markup/test/browser_markup_load_01.js
+++ b/devtools/client/inspector/markup/test/browser_markup_load_01.js
@@ -9,20 +9,20 @@
 // See https://bugzilla.mozilla.org/show_bug.cgi?id=1036324
 
 const server = createTestHTTPServer();
 
 // Register a slow image handler so we can simulate a long time between
 // a reload and the load event firing.
 server.registerContentType("gif", "image/gif");
 server.registerPathHandler("/slow.gif", function (metadata, response) {
-  info ("Image has been requested");
+  info("Image has been requested");
   response.processAsync();
   setTimeout(() => {
-    info ("Image is responding");
+    info("Image is responding");
     response.finish();
   }, 500);
 });
 
 // Test page load events.
 const TEST_URL = "data:text/html," +
   "<!DOCTYPE html>" +
   "<head><meta charset='utf-8' /></head>" +
@@ -32,27 +32,29 @@ const TEST_URL = "data:text/html," +
   "</body>" +
   "</html>";
 
 add_task(function*() {
   let {inspector, testActor, tab} = yield openInspectorForURL(TEST_URL);
   let domContentLoaded = waitForLinkedBrowserEvent(tab, "DOMContentLoaded");
   let pageLoaded = waitForLinkedBrowserEvent(tab, "load");
 
-  ok (inspector.markup, "There is a markup view");
+  ok(inspector.markup, "There is a markup view");
 
   // Select an element while the tab is in the middle of a slow reload.
   reloadTab(testActor);
   yield domContentLoaded;
   yield chooseWithInspectElementContextMenu("img", testActor);
   yield pageLoaded;
 
   yield inspector.once("markuploaded");
-  ok (inspector.markup, "There is a markup view");
-  is (inspector.markup._elt.children.length, 1, "The markup view is rendering");
+  yield waitForMultipleChildrenUpdates(inspector);
+
+  ok(inspector.markup, "There is a markup view");
+  is(inspector.markup._elt.children.length, 1, "The markup view is rendering");
 });
 
 function* chooseWithInspectElementContextMenu(selector, testActor) {
   yield BrowserTestUtils.synthesizeMouseAtCenter(selector, {
     type: "contextmenu",
     button: 2
   }, gBrowser.selectedBrowser);