Bug 1245468 - Fix parmaeter handling for firefox-ui tests. r?whimboo, r?gps draft
authorSyd Polk <spolk@mozilla.com>
Wed, 24 Feb 2016 16:14:56 -0600
changeset 334663 b3130f5a85cbf0f38e4754482ef2877f152399fa
parent 334101 d848a5628d801a460a7244cbcdea22d328d8b310
child 514963 e52204812447e2caed42cae1a80d26ba968985c5
push id11602
push userspolk@mozilla.com
push dateThu, 25 Feb 2016 19:21:17 +0000
reviewerswhimboo, gps
bugs1245468
milestone47.0a1
Bug 1245468 - Fix parmaeter handling for firefox-ui tests. r?whimboo, r?gps MozReview-Commit-ID: 4npa7eeJAFw
testing/firefox-ui/mach_commands.py
--- a/testing/firefox-ui/mach_commands.py
+++ b/testing/firefox-ui/mach_commands.py
@@ -18,33 +18,29 @@ from mach.decorators import (
 )
 
 
 def setup_argument_parser():
     from firefox_ui_harness.arguments.base import FirefoxUIArguments
     return FirefoxUIArguments()
 
 
-def run_firefox_ui_test(tests, testtype=None,
-                        binary=None, topsrcdir=None, **kwargs):
+def run_firefox_ui_test(tests, testtype=None, topsrcdir=None, **kwargs):
     from mozlog.structured import commandline
     from firefox_ui_harness import cli_functional
     from firefox_ui_harness.arguments import FirefoxUIArguments
 
     parser = FirefoxUIArguments()
     commandline.add_logging_group(parser)
-    args = parser.parse_args()
 
     if not tests:
         tests = [os.path.join(topsrcdir,
                  'testing/firefox-ui/tests/firefox_ui_tests/manifest.ini')]
-    args.tests = tests
 
-    args.binary = binary
-    path, exe = os.path.split(args.binary)
+    args = parser.parse_args(args=tests)
 
     for k, v in kwargs.iteritems():
         setattr(args, k, v)
 
     parser.verify_usage(args)
 
     args.logger = commandline.setup_logging("Firefox UI - Functional Tests",
                                             args,