Bug 1251241 - return from DrawTargetCairo::FillGlyphs if |aFont| is nullptr. r?roc draft
authorBogdan Postelnicu <bogdan.postelnicu@softvision.ro>
Thu, 25 Feb 2016 16:59:34 +0200
changeset 334571 dc349defd9237c026b5869581e1ed970d82ac888
parent 334552 c1e0d1890cfee9d86c8d566b0490053f21e0afc6
child 514937 a4d747056fa6151761eed02b15535430cece6429
push id11576
push userBogdan.Postelnicu@softvision.ro
push dateThu, 25 Feb 2016 14:59:56 +0000
reviewersroc
bugs1251241
milestone47.0a1
Bug 1251241 - return from DrawTargetCairo::FillGlyphs if |aFont| is nullptr. r?roc MozReview-Commit-ID: 56RQO8Fm2AP
gfx/2d/DrawTargetCairo.cpp
--- a/gfx/2d/DrawTargetCairo.cpp
+++ b/gfx/2d/DrawTargetCairo.cpp
@@ -1285,16 +1285,17 @@ DrawTargetCairo::FillGlyphs(ScaledFont *
 
   if (!IsValid()) {
     gfxDebug() << "FillGlyphs bad surface " << cairo_surface_status(cairo_get_group_target(mContext));
     return;
   }
 
   if (!aFont) {
     gfxDevCrash(LogReason::InvalidFont) << "Invalid scaled font";
+    return;
   }
 
   AutoPrepareForDrawing prep(this, mContext);
   AutoClearDeviceOffset clear(aPattern);
 
   ScaledFontBase* scaledFont = static_cast<ScaledFontBase*>(aFont);
   cairo_set_scaled_font(mContext, scaledFont->GetCairoScaledFont());