mozreview: fix indentation (bug 1101611) r?mdoglio draft
authorbyron jones <glob@mozilla.com>
Tue, 23 Feb 2016 13:31:07 +0800
changeset 7318 e668e1a9894407f051d33281a41bae50cdba511c
parent 7313 fc3513aad180a4129c9b4e31e85a3d82713ea800
child 7319 c2e6d518193ecceb78b59ef33861dedbe50c2431
push id659
push userbjones@mozilla.com
push dateThu, 25 Feb 2016 07:01:50 +0000
reviewersmdoglio
bugs1101611
mozreview: fix indentation (bug 1101611) r?mdoglio MozReview-Commit-ID: 3V2VdzlT0AZ
pylib/mozreview/mozreview/static/mozreview/js/init_filediffreviewer.js
--- a/pylib/mozreview/mozreview/static/mozreview/js/init_filediffreviewer.js
+++ b/pylib/mozreview/mozreview/static/mozreview/js/init_filediffreviewer.js
@@ -1,77 +1,77 @@
 $(document).ready(function() {
   var page = RB.PageManager.getPage();
 
-    var FileDiffReviewerData = $('#file-diff-reviewer-data')
-                               .data('file-diff-reviewer');
-    var fileDiffReviewerModels = FileDiffReviewerData.map(function(item){
-      return new RB.FileDiffReviewerModel(item);
-    })
-    var fileDiffReviewerCollection = new RB.FileDiffReviewerCollection(
-      fileDiffReviewerModels
-    );
+  var FileDiffReviewerData = $('#file-diff-reviewer-data')
+                             .data('file-diff-reviewer');
+  var fileDiffReviewerModels = FileDiffReviewerData.map(function(item){
+    return new RB.FileDiffReviewerModel(item);
+  });
+  var fileDiffReviewerCollection = new RB.FileDiffReviewerCollection(
+    fileDiffReviewerModels
+  );
 
-    var getButtonText = function(elem) {
-      if (elem.get('reviewed')) {
-        return 'reviewed';
-      } else {
-        return 'not reviewed';
-      }
-    };
+  var getButtonText = function(elem) {
+    if (elem.get('reviewed')) {
+      return 'reviewed';
+    } else {
+      return 'not reviewed';
+    }
+  };
 
-    var renderDiffButton = function(){
-      $.funcQueue('diff_files').add(function(){
-        fileDiffReviewerCollection.each(function(elem){
-          var diff_box_table = document.getElementById(
-            'file' + elem.get('file_diff_id')
-          );
+  var renderDiffButton = function(){
+    $.funcQueue('diff_files').add(function(){
+      fileDiffReviewerCollection.each(function(elem){
+        var diff_box_table = document.getElementById(
+          'file' + elem.get('file_diff_id')
+        );
 
-          if (diff_box_table != null) {
-            var reviewButton = document.createElement('button');
-            reviewButton.title = 'Click here to change the review status' +
-                                 ' of this file';
-            reviewButton.textContent = getButtonText(elem);
-            reviewButton.classList.add('diff-file-btn');
-            if (elem.get('reviewed')) {
-              reviewButton.classList.add('reviewed');
-            }
+        if (diff_box_table !== null) {
+          var reviewButton = document.createElement('button');
+          reviewButton.title = 'Click here to change the review status' +
+                               ' of this file';
+          reviewButton.textContent = getButtonText(elem);
+          reviewButton.classList.add('diff-file-btn');
+          if (elem.get('reviewed')) {
+            reviewButton.classList.add('reviewed');
+          }
 
-            reviewButton.addEventListener('click', function(event){
-              reviewButton.disabled = true;
-              elem.save({'reviewed': !elem.get('reviewed')},{
-                success: function(){
-                  reviewButton.disabled = false;
-                  reviewButton.textContent = getButtonText(elem);
-                  reviewButton.classList.toggle('reviewed');
-                },
-                error: function(model, response){
-                  reviewButton.disabled = false;
-                }
-              });
+          reviewButton.addEventListener('click', function(event){
+            reviewButton.disabled = true;
+            elem.save({'reviewed': !elem.get('reviewed')},{
+              success: function(){
+                reviewButton.disabled = false;
+                reviewButton.textContent = getButtonText(elem);
+                reviewButton.classList.toggle('reviewed');
+              },
+              error: function(model, response){
+                reviewButton.disabled = false;
+              }
             });
-            diff_box_table.parentElement.appendChild(reviewButton);
-          }
-        });
-        $.funcQueue('diff_files').next();
+          });
+          diff_box_table.parentElement.appendChild(reviewButton);
+        }
       });
-    };
+      $.funcQueue('diff_files').next();
+    });
+  };
 
-    var currentRevision = page.model.get('revision');
-    if (!currentRevision.get('isInterdiff')) {
-      renderDiffButton();
+  var currentRevision = page.model.get('revision');
+  if (!currentRevision.get('isInterdiff')) {
+    renderDiffButton();
+  }
+  // Listening to a route change seems to be the only way
+  // to know if the user requested an interdiff or a revision
+  // using the revision slider. The 'isInterdiff' property above
+  // can only be used once on page load because it's not updated
+  // when the user selects a different revision range using the slider.
+  page.router.on('route:revision', function(revision) {
+    // If the user requests an interdiff `revision` is a range of revision
+    // numbers separated by a dash.
+    if (revision.indexOf('-') === -1) {
+      // We still need to wait for an update of the FileDiff collection
+      // to make sure we trigger a render of the diff buttons AFTER
+      // the DiffFile views are rendered.
+      page.model.get('files').once('update', renderDiffButton);
     }
-    // Listening to a route change seems to be the only way
-    // to know if the user requested an interdiff or a revision
-    // using the revision slider. The 'isInterdiff' property above
-    // can only be used once on page load because it's not updated
-    // when the user selects a different revision range using the slider.
-    page.router.on('route:revision', function(revision) {
-      // If the user requests an interdiff `revision` is a range of revision
-      // numbers separated by a dash.
-      if (revision.indexOf('-') === -1) {
-        // We still need to wait for an update of the FileDiff collection
-        // to make sure we trigger a render of the diff buttons AFTER
-        // the DiffFile views are rendered.
-        page.model.get('files').once('update', renderDiffButton);
-      }
-    });
+  });
 });