Bug 1250641 - Fix passing in test parameter to ./mach external-media-tests. r?gps, r?maja_zf draft
authorSyd Polk <spolk@mozilla.com>
Wed, 24 Feb 2016 14:34:54 -0600
changeset 334232 e71278379be9fb581af9679e22a395e14496a277
parent 333377 a9e33d8c48b5ca93ca1937eba4220f681a0f05ec
child 514858 1517b8412298df118059186965d61192ce64c801
push id11488
push userspolk@mozilla.com
push dateWed, 24 Feb 2016 20:36:48 +0000
reviewersgps, maja_zf
bugs1250641
milestone47.0a1
Bug 1250641 - Fix passing in test parameter to ./mach external-media-tests. r?gps, r?maja_zf MozReview-Commit-ID: JxXPjISZDZ0
dom/media/test/external/mach_commands.py
--- a/dom/media/test/external/mach_commands.py
+++ b/dom/media/test/external/mach_commands.py
@@ -29,25 +29,22 @@ def run_external_media_test(tests, testt
         MediaTestRunner,
         mn_cli,
     )
 
     from mozlog.structured import commandline
 
     parser = MediaTestArguments()
     commandline.add_logging_group(parser)
-    args = parser.parse_args()
 
     if not tests:
         tests = [os.path.join(topsrcdir,
                  'dom/media/test/external/external_media_tests/manifest.ini')]
-    args.tests = tests
 
-    if not args.binary:
-        args.binary = kwargs['binary']
+    args = parser.parse_args(args=tests)
 
     for k, v in kwargs.iteritems():
         setattr(args, k, v)
 
     parser.verify_usage(args)
 
     args.logger = commandline.setup_logging("Firefox External Media Tests",
                                             args,