Bug 1247636 - Close Cursor in GeckoSmsManager.createThreadCursor. r=sebastian draft
authorMichael Comella <michael.l.comella@gmail.com>
Mon, 22 Feb 2016 15:14:00 -0800
changeset 333184 1aed33941186ad10fd129989fa6879dcb4bfaf5f
parent 333183 ac512df5428e2fce834aebc1cd988a1d30afa176
child 514664 271057d3d8905d7cf954a6384cde928622022aee
push id11290
push usermichael.l.comella@gmail.com
push dateMon, 22 Feb 2016 23:14:29 +0000
reviewerssebastian
bugs1247636
milestone47.0a1
Bug 1247636 - Close Cursor in GeckoSmsManager.createThreadCursor. r=sebastian MozReview-Commit-ID: HKDr4CiCRap
mobile/android/base/java/org/mozilla/gecko/GeckoSmsManager.java
--- a/mobile/android/base/java/org/mozilla/gecko/GeckoSmsManager.java
+++ b/mobile/android/base/java/org/mozilla/gecko/GeckoSmsManager.java
@@ -1109,16 +1109,19 @@ public class GeckoSmsManager
         try {
           ContentResolver cr = GeckoAppShell.getContext().getContentResolver();
           Cursor cursor = cr.query(kSmsThreadsContentUri,
                                    kThreadProjection,
                                    null,
                                    null,
                                    "date DESC");
           if (cursor == null || !cursor.moveToFirst()) {
+            if (cursor != null) {
+              cursor.close();
+            }
             notifyCursorDone(mRequestId);
             return;
           }
 
           MessagesListManager.getInstance().add(mRequestId, cursor);
 
           getThreadFromCursorAndNotify(cursor, mRequestId);
         } catch (Exception e) {