Bug 1249144 - [webext] fix sorting collected frame details in webNavigation tests. r?kmag draft
authorLuca Greco <lgreco@mozilla.com>
Fri, 19 Feb 2016 04:09:16 +0100
changeset 332754 ac05867718f7510bf4ba7c69f56b2ee7800a6bb9
parent 331665 33fc723946aa45248df83c204f256816deafeede
child 514605 d4e1dd672cf79c782ff468cb8f876eb90a739257
push id11229
push userluca.greco@alcacoop.it
push dateSat, 20 Feb 2016 22:40:39 +0000
reviewerskmag
bugs1249144
milestone47.0a1
Bug 1249144 - [webext] fix sorting collected frame details in webNavigation tests. r?kmag MozReview-Commit-ID: ay5fGRGSpW
browser/components/extensions/test/browser/browser_ext_webNavigation_getFrames.js
--- a/browser/components/extensions/test/browser/browser_ext_webNavigation_getFrames.js
+++ b/browser/components/extensions/test/browser/browser_ext_webNavigation_getFrames.js
@@ -134,17 +134,21 @@ add_task(function* testWebNavigationFram
     getFrameResults,
   } = yield extension.awaitMessage("webNavigationFrames.done");
 
   is(getAllFramesDetails.length, 3, "expected number of frames found");
   is(getAllFramesDetails.length, collectedDetails.length,
      "number of frames found should equal the number onCompleted events collected");
 
   // ordered by frameId
-  let sortByFrameId = (el) => el ? el.frameId : -1;
+  let sortByFrameId = (el1, el2) => {
+    let val1 = el1 ? el1.frameId : -1;
+    let val2 = el2 ? el2.frameId : -1;
+    return val1 - val2;
+  };
 
   collectedDetails = collectedDetails.sort(sortByFrameId);
   getAllFramesDetails = getAllFramesDetails.sort(sortByFrameId);
   getFrameResults = getFrameResults.sort(sortByFrameId);
 
   info("check frame details content");
 
   is(getFrameResults.length, getAllFramesDetails.length,