Bug 1248105 - Move CSSPseudoElement::GetParentObject out of header, r?boris draft
authorMartin Thomson <martin.thomson@gmail.com>
Mon, 15 Feb 2016 11:51:34 +1100
changeset 330948 204442f0090300895202f70f2d16c1c245545377
parent 330947 cd1e89ce1b58461aaf32905d2044ee64051ea338
child 514272 2899c1026503c6f8ce7942dccb28a3b7bda165fa
push id10862
push usermartin.thomson@gmail.com
push dateMon, 15 Feb 2016 01:23:49 +0000
reviewersboris
bugs1248105
milestone47.0a1
Bug 1248105 - Move CSSPseudoElement::GetParentObject out of header, r?boris MozReview-Commit-ID: 5vZQlv8q0df
dom/animation/CSSPseudoElement.cpp
dom/animation/CSSPseudoElement.h
--- a/dom/animation/CSSPseudoElement.cpp
+++ b/dom/animation/CSSPseudoElement.cpp
@@ -31,16 +31,22 @@ CSSPseudoElement::~CSSPseudoElement()
 {
   // Element might have been unlinked already, so we have to do null check.
   if (mParentElement) {
     mParentElement->DeleteProperty(
       GetCSSPseudoElementPropertyAtom(mPseudoType));
   }
 }
 
+ParentObject
+CSSPseudoElement::GetParentObject() const
+{
+  return mParentElement->GetParentObject();
+}
+
 JSObject*
 CSSPseudoElement::WrapObject(JSContext* aCx, JS::Handle<JSObject*> aGivenProto)
 {
   return CSSPseudoElementBinding::Wrap(aCx, this, aGivenProto);
 }
 
 void
 CSSPseudoElement::GetAnimations(nsTArray<RefPtr<Animation>>& aRetVal)
--- a/dom/animation/CSSPseudoElement.h
+++ b/dom/animation/CSSPseudoElement.h
@@ -27,20 +27,17 @@ class CSSPseudoElement final : public ns
 public:
   NS_INLINE_DECL_CYCLE_COLLECTING_NATIVE_REFCOUNTING(CSSPseudoElement)
   NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_NATIVE_CLASS(CSSPseudoElement)
 
 protected:
   virtual ~CSSPseudoElement();
 
 public:
-  ParentObject GetParentObject() const
-  {
-    return mParentElement->GetParentObject();
-  }
+  ParentObject GetParentObject() const;
 
   virtual JSObject* WrapObject(JSContext* aCx,
                                JS::Handle<JSObject*> aGivenProto) override;
 
   nsCSSPseudoElements::Type GetType() const { return mPseudoType; }
   void GetType(nsString& aRetVal) const
   {
     MOZ_ASSERT(nsCSSPseudoElements::GetPseudoAtom(mPseudoType),