Bug 1247933 - do not perform null check on aClient since we know for sure it's a valid pointert. r?sotaro draft
authorBogdan Postelnicu <bogdan.postelnicu@softvision.ro>
Mon, 15 Feb 2016 10:33:46 +0200
changeset 330966 95e90b921eebe4ea5486583d805a5a65d9ed2a94
parent 330910 e355cacefc881ba360d412853b57e8e060e966f4
child 514278 d3d8f1476f63f5e23fc515e143d321550d5593a0
push id10871
push userBogdan.Postelnicu@softvision.ro
push dateMon, 15 Feb 2016 08:35:14 +0000
reviewerssotaro
bugs1247933
milestone47.0a1
Bug 1247933 - do not perform null check on aClient since we know for sure it's a valid pointert. r?sotaro MozReview-Commit-ID: 5AiIprIVNAS
dom/media/systemservices/MediaSystemResourceManager.cpp
--- a/dom/media/systemservices/MediaSystemResourceManager.cpp
+++ b/dom/media/systemservices/MediaSystemResourceManager.cpp
@@ -237,19 +237,17 @@ MediaSystemResourceManager::AcquireSyncN
     MOZ_ASSERT(client == aClient);
 
     aClient->mIsSync = true; // sync request
 
     if (InImageBridgeChildThread()) {
       HandleAcquireResult(aClient->mId, false);
       return false;
     }
-    if (!aClient ||
-        !client ||
-        client != aClient) {
+    if (!client || client != aClient) {
       HandleAcquireResult(aClient->mId, false);
       return false;
     }
     // State Check
     if (aClient->mResourceState != MediaSystemResourceClient::RESOURCE_STATE_START) {
       HandleAcquireResult(aClient->mId, false);
       return false;
     }