Bug 1247912 - convert left side expression to int64_t when assigning to mCookiesLifetimeSec in order to avoid overflow. r?jdm draft
authorBogdan Postelnicu <bogdan.postelnicu@softvision.ro>
Fri, 12 Feb 2016 14:40:16 +0200
changeset 330649 d11aa648ee707df61f03550c981f668ad32c39f7
parent 330467 576a6dcde5b68c2ea45324ed5ce1dabb7d833d09
child 514211 8ab3f55db9aad52d174938444fa892c446014aee
push id10798
push userBogdan.Postelnicu@softvision.ro
push dateFri, 12 Feb 2016 12:41:45 +0000
reviewersjdm
bugs1247912
milestone47.0a1
Bug 1247912 - convert left side expression to int64_t when assigning to mCookiesLifetimeSec in order to avoid overflow. r?jdm MozReview-Commit-ID: H6LdaC2RfPs
extensions/cookie/nsCookiePermission.cpp
--- a/extensions/cookie/nsCookiePermission.cpp
+++ b/extensions/cookie/nsCookiePermission.cpp
@@ -114,17 +114,17 @@ nsCookiePermission::PrefChanged(nsIPrefB
       val = ACCEPT_NORMALLY;
     }
     mCookiesLifetimePolicy = val;
   }
 
   if (PREF_CHANGED(kCookiesLifetimeDays) &&
       NS_SUCCEEDED(aPrefBranch->GetIntPref(kCookiesLifetimeDays, &val)))
     // save cookie lifetime in seconds instead of days
-    mCookiesLifetimeSec = val * 24 * 60 * 60;
+    mCookiesLifetimeSec = (int64_t)val * 24 * 60 * 60;
 }
 
 NS_IMETHODIMP
 nsCookiePermission::SetAccess(nsIURI         *aURI,
                               nsCookieAccess  aAccess)
 {
   // Lazily initialize ourselves
   if (!EnsureInitialized())