autoland: set a max height on the commit confirmation dialog (bug 1247569) r?dminor draft
authorbyron jones <glob@mozilla.com>
Fri, 12 Feb 2016 00:46:58 +0800
changeset 7228 f35783a3460ba8e7206586affd6b5d2b61f21569
parent 7227 aac0473d2ed832d913b32b3ef76ac21d84300c26
push id621
push userbjones@mozilla.com
push dateThu, 11 Feb 2016 16:49:58 +0000
reviewersdminor
bugs1247569
autoland: set a max height on the commit confirmation dialog (bug 1247569) r?dminor djblet's modal box doesn't restrict the height of content to the window, resulting in a dialog with unreadable content when there are a lot of commits. Unfortunately fixing this correctly by bounding the dialog to the window isn't possible with RB css, so we just cap the maximum height at 600px. MozReview-Commit-ID: HlTCNztV8ci
pylib/mozreview/mozreview/static/mozreview/css/review.less
--- a/pylib/mozreview/mozreview/static/mozreview/css/review.less
+++ b/pylib/mozreview/mozreview/static/mozreview/css/review.less
@@ -96,16 +96,21 @@ label[for="mozreview-autoland-try-syntax
   margin-bottom: 1em;
 
   #autoland-repo,
   .autoland-commit-desc {
     font-weight: bold;
     margin-top: 1em;
   }
 
+  #autoland-commits {
+    max-height: 600px;
+    overflow-y: auto;
+  }
+
   .autoland-commit-rev {
     font-family: monospace;
     margin-right: 2ch;
   }
 
   .autoland-commit-warning {
     color: red;
     font-weight: bold;