Bug 1231132 - setting mStatus in constructors to NS_OK in order to silence a Coverity checker. It's not a bug since this gets set by ScheduleLoadEventIfNeeded, and is only used after that has been called. r?dbaron
MozReview-Commit-ID: CEKFr3xerIg
--- a/layout/style/Loader.cpp
+++ b/layout/style/Loader.cpp
@@ -325,17 +325,18 @@ SheetLoadData::SheetLoadData(Loader* aLo
mMustNotify(false),
mWasAlternate(aIsAlternate),
mParsingMode(eAuthorSheetFeatures),
mUseSystemPrincipal(false),
mSheetAlreadyComplete(false),
mOwningElement(aOwningElement),
mObserver(aObserver),
mLoaderPrincipal(aLoaderPrincipal),
- mRequestingNode(aRequestingNode)
+ mRequestingNode(aRequestingNode),
+ mStatus(NS_OK)
{
NS_PRECONDITION(mLoader, "Must have a loader!");
}
SheetLoadData::SheetLoadData(Loader* aLoader,
nsIURI* aURI,
CSSStyleSheet* aSheet,
SheetLoadData* aParentData,
@@ -356,17 +357,18 @@ SheetLoadData::SheetLoadData(Loader* aLo
mMustNotify(false),
mWasAlternate(false),
mParsingMode(eAuthorSheetFeatures),
mUseSystemPrincipal(false),
mSheetAlreadyComplete(false),
mOwningElement(nullptr),
mObserver(aObserver),
mLoaderPrincipal(aLoaderPrincipal),
- mRequestingNode(aRequestingNode)
+ mRequestingNode(aRequestingNode),
+ mStatus(NS_OK)
{
NS_PRECONDITION(mLoader, "Must have a loader!");
if (mParentData) {
mSyncLoad = mParentData->mSyncLoad;
mIsNonDocumentSheet = mParentData->mIsNonDocumentSheet;
mParsingMode = mParentData->mParsingMode;
mUseSystemPrincipal = mParentData->mUseSystemPrincipal;
++(mParentData->mPendingChildren);
@@ -400,17 +402,18 @@ SheetLoadData::SheetLoadData(Loader* aLo
mWasAlternate(false),
mParsingMode(aParsingMode),
mUseSystemPrincipal(aUseSystemPrincipal),
mSheetAlreadyComplete(false),
mOwningElement(nullptr),
mObserver(aObserver),
mLoaderPrincipal(aLoaderPrincipal),
mRequestingNode(aRequestingNode),
- mCharsetHint(aCharset)
+ mCharsetHint(aCharset),
+ mStatus(NS_OK)
{
NS_PRECONDITION(mLoader, "Must have a loader!");
NS_PRECONDITION(aParsingMode == eAuthorSheetFeatures ||
aParsingMode == eUserSheetFeatures ||
aParsingMode == eAgentSheetFeatures,
"Unrecognized sheet parsing mode");
NS_POSTCONDITION(!mUseSystemPrincipal || mSyncLoad,