Bug 1246460 - pocket UI disappeared, r?MattN draft
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Mon, 08 Feb 2016 10:08:43 +0000
changeset 329525 80c764656c1f686d726199db379a0a12c8cba86e
parent 329519 a0d0344ed47a65f5c36802b61b25c0520cec421f
child 513970 e05831d3e95a5b1466b4faa5f47faa478af0c284
push id10538
push usergijskruitbosch@gmail.com
push dateMon, 08 Feb 2016 10:10:03 +0000
reviewersMattN
bugs1246460
milestone47.0a1
Bug 1246460 - pocket UI disappeared, r?MattN
browser/base/content/test/social/browser.ini
browser/base/content/test/social/browser_pocket_ui_check.js
browser/extensions/pocket/bootstrap.js
--- a/browser/base/content/test/social/browser.ini
+++ b/browser/base/content/test/social/browser.ini
@@ -27,16 +27,17 @@ support-files =
   social_worker.js
   unchecked.jpg
 
 [browser_aboutHome_activation.js]
 [browser_addons.js]
 skip-if = e10s && debug # Leaking docshells (bug 1150147)
 [browser_blocklist.js]
 skip-if = e10s && debug # Leaking docshells (bug 1150147)
+[browser_pocket_ui_check.js]
 [browser_share.js]
 skip-if = true # bug 1115131
 [browser_social_activation.js]
 skip-if = e10s && debug # e10s/Linux/Debug Leaking docshells (bug 1150147)
 [browser_social_chatwindow.js]
 skip-if = true # Bug 1245798 'document-element-inserted' is not fired for chat windows anymore, so no mozSocial
 [browser_social_chatwindow_resize.js]
 skip-if = true # Bug 1245798 'document-element-inserted' is not fired for chat windows anymore, so no mozSocial
new file mode 100644
--- /dev/null
+++ b/browser/base/content/test/social/browser_pocket_ui_check.js
@@ -0,0 +1,21 @@
+"use strict";
+
+add_task(function*() {
+  let pocketAddon = yield new Promise(resolve => {
+    AddonManager.getAddonByID("firefox@getpocket.com", resolve);
+  });
+  if (!pocketAddon) {
+    ok(true, "Pocket is not installed");
+    return;
+  }
+  if (!Services.prefs.getBoolPref("extensions.pocket.enabled")) {
+    ok(true, "Pocket add-on is not enabled");
+    return;
+  }
+
+  for (let id of ["panelMenu_pocket", "menu_pocket", "BMB_pocket",
+                  "panelMenu_pocketSeparator", "menu_pocketSeparator",
+                  "BMB_pocketSeparator"]) {
+    ok(document.getElementById(id), "Should see element with id " + id);
+  }
+});
--- a/browser/extensions/pocket/bootstrap.js
+++ b/browser/extensions/pocket/bootstrap.js
@@ -417,17 +417,17 @@ var PocketOverlay = {
       let sep = createElementWithAttrs(document, "menuseparator", {
         "id": "menu_pocketSeparator"
       });
       sib.parentNode.insertBefore(menu, sib);
       sib.parentNode.insertBefore(sep, sib);
     }
 
     // add to bookmarks-menu-button
-    sib = document.getElementById("BMB_subscribeToPageMenuitem");
+    sib = document.getElementById("BMB_bookmarksToolbar");
     if (sib && !document.getElementById("BMB_pocket")) {
       let menu = createElementWithAttrs(document, "menuitem", {
         "id": "BMB_pocket",
         "label": gPocketBundle.GetStringFromName("pocketMenuitem.label"),
         "class": "menuitem-iconic bookmark-item subviewbutton",
         "oncommand": "openUILink(Pocket.listURL, event);"
       });
       let sep = createElementWithAttrs(document, "menuseparator", {