Bug 1246411 - Access to properties is better written using dot notation; r?automatedtester draft
authorAndreas Tolfsen <ato@mozilla.com>
Sat, 06 Feb 2016 18:19:25 +0000
changeset 329410 d432fc7323535e55fa5d835c76bec3b350c85775
parent 329409 7d6c6ee569c7da571a6040f3d5f656a67d20ea49
child 329411 ec47a18769d6e042829e5d7fd4339bf4c44d46be
push id10518
push userbmo:ato@mozilla.com
push dateSat, 06 Feb 2016 18:25:47 +0000
reviewersautomatedtester
bugs1246411
milestone47.0a1
Bug 1246411 - Access to properties is better written using dot notation; r?automatedtester MozReview-Commit-ID: KlmrhB8GKpY
testing/marionette/driver.js
--- a/testing/marionette/driver.js
+++ b/testing/marionette/driver.js
@@ -635,20 +635,20 @@ GeckoDriver.prototype.setSessionCapabili
     }
 
     for (let key in from) {
       switch (key) {
         case "desiredCapabilities":
           to = copy(from[key], to);
           break;
         case "requiredCapabilities":
-          if (from[key]["proxy"]) {
-              this.setUpProxy(from[key]["proxy"]);
-              to["proxy"] = from[key]["proxy"];
-              delete from[key]["proxy"];
+          if (from[key].proxy) {
+              this.setUpProxy(from[key].proxy);
+              to.proxy = from[key].proxy;
+              delete from[key].proxy;
           }
           for (let caps in from[key]) {
             if (from[key][caps] !== this.sessionCapabilities[caps]) {
               errors.push(from[key][caps] + " does not equal " +
                   this.sessionCapabilities[caps])   ;
             }
           }
           break;