Bug 1245649: Turn on valid-typeof, no-invalid-regexp, no-empty-pattern and no-empty-character-class. r=felipe
authorDave Townsend <dtownsend@oxymoronical.com>
Wed, 03 Feb 2016 17:38:13 -0800
changeset 329079 8b6ee0350b2cd5d8b583c3aa7e6844ee070b1c93
parent 329078 cb217f7271c24838782ff4f772af29a7ba9f53e8
child 329080 f3018a3c2de52184b7a49a9e61c1dfb7817d475a
push id10463
push userdtownsend@mozilla.com
push dateFri, 05 Feb 2016 03:02:33 +0000
reviewersfelipe
bugs1245649
milestone47.0a1
Bug 1245649: Turn on valid-typeof, no-invalid-regexp, no-empty-pattern and no-empty-character-class. r=felipe
toolkit/.eslintrc
--- a/toolkit/.eslintrc
+++ b/toolkit/.eslintrc
@@ -66,35 +66,35 @@
 
     // If an if block ends with a return no need for an else block
     // "no-else-return": 2,
 
     // No empty statements
     // "no-empty": 2,
 
     // No empty character classes in regex
-    // "no-empty-character-class": 2,
+    "no-empty-character-class": 2,
 
     // Disallow empty destructuring
-    // "no-empty-pattern": 2,
+    "no-empty-pattern": 2,
 
     // No assiging to exception variable
     // "no-ex-assign": 2,
 
     // No using !! where casting to boolean is already happening
     // "no-extra-boolean-cast": 2,
 
     // No double semicolon
     "no-extra-semi": 2,
 
     // No overwriting defined functions
     // "no-func-assign": 2,
 
     // No invalid regular expresions
-    // "no-invalid-regexp": 2,
+    "no-invalid-regexp": 2,
 
     // No odd whitespace characters
     // "no-irregular-whitespace": 2,
 
     // No single if block inside an else block
     // "no-lonely-if": 2,
 
     // No mixing spaces and tabs in indent
@@ -186,11 +186,11 @@
 
     // ++ and -- should not need spacing
     // "space-unary-ops": [2, { "words": true, "nonwords": false }],
 
     // No comparisons to NaN
     // "use-isnan": 2,
 
     // Only check typeof against valid results
-    // "valid-typeof": 2,
+    "valid-typeof": 2,
   }
 }