Bug 1143096 - Init all WebMBufferedParser members - r?jya draft
authorGerald Squelart <gsquelart@mozilla.com>
Wed, 03 Feb 2016 10:54:01 +1100
changeset 328337 3ce31651008c3dcac4ae4557177aa93d39ebdce0
parent 328271 5f9ba76eb3b1fd9377bbdb4cc2f98a7e75eabdfb
child 513805 49079b99f4e1fcb218976b4c2767dc91e980cefe
push id10348
push usergsquelart@mozilla.com
push dateTue, 02 Feb 2016 23:54:22 +0000
reviewersjya
bugs1143096
milestone47.0a1
Bug 1143096 - Init all WebMBufferedParser members - r?jya Initialize all WebMBufferedParser members, mainly to remove compiler warnings. 'mClusterTimecode' and 'mClusterOffset' are probably genuine potential issues, see bug 1143096 comment 2 for details.
dom/media/webm/WebMBufferedParser.h
--- a/dom/media/webm/WebMBufferedParser.h
+++ b/dom/media/webm/WebMBufferedParser.h
@@ -55,20 +55,29 @@ struct WebMTimeDataOffset
 struct WebMBufferedParser
 {
   explicit WebMBufferedParser(int64_t aOffset)
     : mStartOffset(aOffset)
     , mCurrentOffset(aOffset)
     , mInitEndOffset(-1)
     , mBlockEndOffset(-1)
     , mState(READ_ELEMENT_ID)
+    , mNextState(READ_ELEMENT_ID)
     , mVIntRaw(false)
     , mLastInitStartOffset(-1)
     , mClusterSyncPos(0)
+    , mVIntLeft(0)
+    , mBlockSize(0)
+    , mClusterTimecode(0)
+    , mClusterOffset(0)
     , mClusterEndOffset(-1)
+    , mBlockOffset(0)
+    , mBlockTimecode(0)
+    , mBlockTimecodeLength(0)
+    , mSkipBytes(0)
     , mTimecodeScale(1000000)
     , mGotTimecodeScale(false)
   {
     if (mStartOffset != 0) {
       mState = FIND_CLUSTER_SYNC;
     }
   }