Bug 1234020: Part 2k - [webext] Return promises from the windows API. r=rpl draft
authorKris Maglione <maglione.k@gmail.com>
Mon, 01 Feb 2016 18:28:00 -0800
changeset 328983 1c167b8bb915f45ac1ced1eef69c2708e3ee2fd5
parent 328982 d550750d04b7fe517d03232745925fa10ee50eba
child 328984 b4496250f1446d69f50e43f88f012824c47c038d
push id10445
push usermaglione.k@gmail.com
push dateThu, 04 Feb 2016 21:38:16 +0000
reviewersrpl
bugs1234020
milestone47.0a1
Bug 1234020: Part 2k - [webext] Return promises from the windows API. r=rpl
browser/components/extensions/ext-windows.js
browser/components/extensions/schemas/windows.json
--- a/browser/components/extensions/ext-windows.js
+++ b/browser/components/extensions/ext-windows.js
@@ -4,17 +4,16 @@
 
 XPCOMUtils.defineLazyServiceGetter(this, "aboutNewTabService",
                                    "@mozilla.org/browser/aboutnewtab-service;1",
                                    "nsIAboutNewTabService");
 
 Cu.import("resource://gre/modules/ExtensionUtils.jsm");
 var {
   EventManager,
-  runSafe,
 } = ExtensionUtils;
 
 extensions.registerSchemaAPI("windows", null, (extension, context) => {
   return {
     windows: {
       onCreated:
       new WindowEventManager(context, "windows.onCreated", "domwindowopened", (fire, window) => {
         fire(WindowManager.convert(extension, window));
@@ -35,44 +34,38 @@ extensions.registerSchemaAPI("windows", 
         AllWindowEvents.addListener("focus", listener);
         AllWindowEvents.addListener("blur", listener);
         return () => {
           AllWindowEvents.removeListener("focus", listener);
           AllWindowEvents.removeListener("blur", listener);
         };
       }).api(),
 
-      get: function(windowId, getInfo, callback) {
+      get: function(windowId, getInfo) {
         let window = WindowManager.getWindow(windowId);
-        runSafe(context, callback, WindowManager.convert(extension, window, getInfo));
+        return Promise.resolve(WindowManager.convert(extension, window, getInfo));
       },
 
-      getCurrent: function(getInfo, callback) {
+      getCurrent: function(getInfo) {
         let window = currentWindow(context);
-        runSafe(context, callback, WindowManager.convert(extension, window, getInfo));
+        return Promise.resolve(WindowManager.convert(extension, window, getInfo));
       },
 
-      getLastFocused: function(getInfo, callback) {
+      getLastFocused: function(getInfo) {
         let window = WindowManager.topWindow;
-        runSafe(context, callback, WindowManager.convert(extension, window, getInfo));
+        return Promise.resolve(WindowManager.convert(extension, window, getInfo));
       },
 
-      getAll: function(getInfo, callback) {
-        let e = Services.wm.getEnumerator("navigator:browser");
-        let windows = [];
-        while (e.hasMoreElements()) {
-          let window = e.getNext();
-          if (window.document.readyState == "complete") {
-            windows.push(WindowManager.convert(extension, window, getInfo));
-          }
-        }
-        runSafe(context, callback, windows);
+      getAll: function(getInfo) {
+        let windows = Array.from(WindowListManager.browserWindows(),
+                                 window => WindowManager.convert(extension, window, getInfo));
+        return Promise.resolve(windows);
       },
 
-      create: function(createData, callback) {
+      create: function(createData) {
         function mkstr(s) {
           let result = Cc["@mozilla.org/supports-string;1"].createInstance(Ci.nsISupportsString);
           result.data = s;
           return result;
         }
 
         let args = Cc["@mozilla.org/supports-array;1"].createInstance(Ci.nsISupportsArray);
         if (createData.url !== null) {
@@ -109,43 +102,41 @@ extensions.registerSchemaAPI("windows", 
         if (createData.width !== null || createData.height !== null) {
           let width = createData.width !== null ? createData.width : window.outerWidth;
           let height = createData.height !== null ? createData.height : window.outerHeight;
           window.resizeTo(width, height);
         }
 
         // TODO: focused, type, state
 
-        window.addEventListener("load", function listener() {
-          window.removeEventListener("load", listener);
-          if (callback) {
-            runSafe(context, callback, WindowManager.convert(extension, window));
-          }
+        return new Promise(resolve => {
+          window.addEventListener("load", function listener() {
+            window.removeEventListener("load", listener);
+            resolve(WindowManager.convert(extension, window));
+          });
         });
       },
 
-      update: function(windowId, updateInfo, callback) {
+      update: function(windowId, updateInfo) {
         let window = WindowManager.getWindow(windowId);
         if (updateInfo.focused) {
           Services.focus.activeWindow = window;
         }
         // TODO: All the other properties...
 
-        if (callback) {
-          runSafe(context, callback, WindowManager.convert(extension, window));
-        }
+        return Promise.resolve(WindowManager.convert(extension, window));
       },
 
-      remove: function(windowId, callback) {
+      remove: function(windowId) {
         let window = WindowManager.getWindow(windowId);
         window.close();
 
-        let listener = () => {
-          AllWindowEvents.removeListener("domwindowclosed", listener);
-          if (callback) {
-            runSafe(context, callback);
-          }
-        };
-        AllWindowEvents.addListener("domwindowclosed", listener);
+        return new Promise(resolve => {
+          let listener = () => {
+            AllWindowEvents.removeListener("domwindowclosed", listener);
+            resolve();
+          };
+          AllWindowEvents.addListener("domwindowclosed", listener);
+        });
       },
     },
   };
 });
--- a/browser/components/extensions/schemas/windows.json
+++ b/browser/components/extensions/schemas/windows.json
@@ -32,36 +32,77 @@
         "type": "string",
         "description": "The state of this browser window. Under some circumstances a Window may not be assigned state property, for example when querying closed windows from the $(ref:sessions) API.",
         "enum": ["normal", "minimized", "maximized", "fullscreen", "docked"]
       },
       {
         "id": "Window",
         "type": "object",
         "properties": {
-          "id": {"type": "integer", "optional": true, "minimum": 0, "description": "The ID of the window. Window IDs are unique within a browser session. Under some circumstances a Window may not be assigned an ID, for example when querying windows using the $(ref:sessions) API, in which case a session ID may be present."},
-          "focused": {"type": "boolean", "description": "Whether the window is currently the focused window."},
-          "top": {"type": "integer", "optional": true, "description": "The offset of the window from the top edge of the screen in pixels. Under some circumstances a Window may not be assigned top property, for example when querying closed windows from the $(ref:sessions) API."},
-          "left": {"type": "integer", "optional": true, "description": "The offset of the window from the left edge of the screen in pixels. Under some circumstances a Window may not be assigned left property, for example when querying closed windows from the $(ref:sessions) API."},
-          "width": {"type": "integer", "optional": true, "description": "The width of the window, including the frame, in pixels. Under some circumstances a Window may not be assigned width property, for example when querying closed windows from the $(ref:sessions) API."},
-          "height": {"type": "integer", "optional": true, "description": "The height of the window, including the frame, in pixels. Under some circumstances a Window may not be assigned height property, for example when querying closed windows from the $(ref:sessions) API."},
-          "tabs": {"type": "array", "items": { "$ref": "tabs.Tab" }, "optional": true, "description": "Array of $(ref:tabs.Tab) objects representing the current tabs in the window."},
-          "incognito": {"type": "boolean", "description": "Whether the window is incognito."},
+          "id": {
+            "type": "integer",
+            "optional": true,
+            "minimum": 0,
+            "description": "The ID of the window. Window IDs are unique within a browser session. Under some circumstances a Window may not be assigned an ID, for example when querying windows using the $(ref:sessions) API, in which case a session ID may be present."
+          },
+          "focused": {
+            "type": "boolean",
+            "description": "Whether the window is currently the focused window."
+          },
+          "top": {
+            "type": "integer",
+            "optional": true,
+            "description": "The offset of the window from the top edge of the screen in pixels. Under some circumstances a Window may not be assigned top property, for example when querying closed windows from the $(ref:sessions) API."
+          },
+          "left": {
+            "type": "integer",
+            "optional": true,
+            "description": "The offset of the window from the left edge of the screen in pixels. Under some circumstances a Window may not be assigned left property, for example when querying closed windows from the $(ref:sessions) API."
+          },
+          "width": {
+            "type": "integer",
+            "optional": true,
+            "description": "The width of the window, including the frame, in pixels. Under some circumstances a Window may not be assigned width property, for example when querying closed windows from the $(ref:sessions) API."
+          },
+          "height": {
+            "type": "integer",
+            "optional": true,
+            "description": "The height of the window, including the frame, in pixels. Under some circumstances a Window may not be assigned height property, for example when querying closed windows from the $(ref:sessions) API."
+          },
+          "tabs": {
+            "type": "array",
+            "items": { "$ref": "tabs.Tab" },
+            "optional": true,
+            "description": "Array of $(ref:tabs.Tab) objects representing the current tabs in the window."
+          },
+          "incognito": {
+            "type": "boolean",
+            "description": "Whether the window is incognito."
+          },
           "type": {
             "$ref": "WindowType",
             "optional": true,
             "description": "The type of browser window this is."
           },
           "state": {
             "$ref": "WindowState",
             "optional": true,
             "description": "The state of this browser window."
           },
-          "alwaysOnTop": {"unsupported": true, "type": "boolean", "description": "Whether the window is set to be always on top."},
-          "sessionId": {"unsupported": true, "type": "string", "optional": true, "description": "The session ID used to uniquely identify a Window obtained from the $(ref:sessions) API."}
+          "alwaysOnTop": {
+            "unsupported": true,
+            "type": "boolean",
+            "description": "Whether the window is set to be always on top."
+          },
+          "sessionId": {
+            "unsupported": true,
+            "type": "string",
+            "optional": true,
+            "description": "The session ID used to uniquely identify a Window obtained from the $(ref:sessions) API."
+          }
         }
       },
       {
         "id": "CreateType",
         "type": "string",
         "description": "Specifies what type of browser window to create. The 'panel' and 'detached_panel' types create a popup unless the '--enable-panels' flag is set.",
         "enum": ["normal", "popup", "panel", "detached_panel"]
       }
@@ -76,141 +117,228 @@
         "description": "The windowId value that represents the $(topic:current-window)[current window]."
       }
     },
     "functions": [
       {
         "name": "get",
         "type": "function",
         "description": "Gets details about a window.",
+        "async": "callback",
         "parameters": [
-          {"type": "integer", "name": "windowId", "minimum": -2},
+          {
+            "type": "integer",
+            "name": "windowId",
+            "minimum": -2
+          },
           {
             "type": "object",
             "name": "getInfo",
             "optional": true,
             "description": "",
             "properties": {
-              "populate": {"type": "boolean", "optional": true, "description": "If true, the $(ref:windows.Window) object will have a <var>tabs</var> property that contains a list of the $(ref:tabs.Tab) objects. The <code>Tab</code> objects only contain the <code>url</code>, <code>title</code> and <code>favIconUrl</code> properties if the extension's manifest file includes the <code>\"tabs\"</code> permission." },
-              "windowTypes": {"type": "array", "items": { "$ref": "WindowType" }, "optional": true, "description": "If set, the $(ref:windows.Window) returned will be filtered based on its type. If unset the default filter is set to <code>['app', 'normal', 'panel', 'popup']</code>, with <code>'app'</code> and <code>'panel'</code> window types limited to the extension's own windows." }
+              "populate": {
+                "type": "boolean",
+                "optional": true,
+                "description": "If true, the $(ref:windows.Window) object will have a <var>tabs</var> property that contains a list of the $(ref:tabs.Tab) objects. The <code>Tab</code> objects only contain the <code>url</code>, <code>title</code> and <code>favIconUrl</code> properties if the extension's manifest file includes the <code>\"tabs\"</code> permission."
+              },
+              "windowTypes": {
+                "type": "array",
+                "items": {
+                  "$ref": "WindowType"
+                },
+                "optional": true,
+                "description": "If set, the $(ref:windows.Window) returned will be filtered based on its type. If unset the default filter is set to <code>['app', 'normal', 'panel', 'popup']</code>, with <code>'app'</code> and <code>'panel'</code> window types limited to the extension's own windows."
+              }
             }
           },
           {
             "type": "function",
             "name": "callback",
             "parameters": [
               {
-                "name": "window", "$ref": "Window"
+                "name": "window",
+                "$ref": "Window"
               }
             ]
           }
         ]
       },
       {
         "name": "getCurrent",
         "type": "function",
         "description": "Gets the $(topic:current-window)[current window].",
+        "async": "callback",
         "parameters": [
           {
             "type": "object",
             "name": "getInfo",
             "optional": true,
             "description": "",
             "properties": {
-              "populate": {"type": "boolean", "optional": true, "description": "If true, the $(ref:windows.Window) object will have a <var>tabs</var> property that contains a list of the $(ref:tabs.Tab) objects. The <code>Tab</code> objects only contain the <code>url</code>, <code>title</code> and <code>favIconUrl</code> properties if the extension's manifest file includes the <code>\"tabs\"</code> permission." },
-              "windowTypes": {"type": "array", "items": { "$ref": "WindowType" }, "optional": true, "description": "If set, the $(ref:windows.Window) returned will be filtered based on its type. If unset the default filter is set to <code>['app', 'normal', 'panel', 'popup']</code>, with <code>'app'</code> and <code>'panel'</code> window types limited to the extension's own windows." }
+              "populate": {
+                "type": "boolean",
+                "optional": true,
+                "description": "If true, the $(ref:windows.Window) object will have a <var>tabs</var> property that contains a list of the $(ref:tabs.Tab) objects. The <code>Tab</code> objects only contain the <code>url</code>, <code>title</code> and <code>favIconUrl</code> properties if the extension's manifest file includes the <code>\"tabs\"</code> permission."
+              },
+              "windowTypes": {
+                "type": "array",
+                "items": { "$ref": "WindowType" },
+                "optional": true,
+                "description": "If set, the $(ref:windows.Window) returned will be filtered based on its type. If unset the default filter is set to <code>['app', 'normal', 'panel', 'popup']</code>, with <code>'app'</code> and <code>'panel'</code> window types limited to the extension's own windows."
+              }
             }
           },
           {
             "type": "function",
             "name": "callback",
             "parameters": [
               {
-                "name": "window", "$ref": "Window"
+                "name": "window",
+                "$ref": "Window"
               }
             ]
           }
         ]
       },
       {
         "name": "getLastFocused",
         "type": "function",
         "description": "Gets the window that was most recently focused &mdash; typically the window 'on top'.",
+        "async": "callback",
         "parameters": [
           {
             "type": "object",
             "name": "getInfo",
             "optional": true,
             "description": "",
             "properties": {
-              "populate": {"type": "boolean", "optional": true, "description": "If true, the $(ref:windows.Window) object will have a <var>tabs</var> property that contains a list of the $(ref:tabs.Tab) objects. The <code>Tab</code> objects only contain the <code>url</code>, <code>title</code> and <code>favIconUrl</code> properties if the extension's manifest file includes the <code>\"tabs\"</code> permission." },
-              "windowTypes": {"type": "array", "items": { "$ref": "WindowType" }, "optional": true, "description": "If set, the $(ref:windows.Window) returned will be filtered based on its type. If unset the default filter is set to <code>['app', 'normal', 'panel', 'popup']</code>, with <code>'app'</code> and <code>'panel'</code> window types limited to the extension's own windows." }
+              "populate": {
+                "type": "boolean",
+                "optional": true,
+                "description": "If true, the $(ref:windows.Window) object will have a <var>tabs</var> property that contains a list of the $(ref:tabs.Tab) objects. The <code>Tab</code> objects only contain the <code>url</code>, <code>title</code> and <code>favIconUrl</code> properties if the extension's manifest file includes the <code>\"tabs\"</code> permission."
+              },
+              "windowTypes": {
+                "type": "array",
+                "items": { "$ref": "WindowType" },
+                "optional": true,
+                "description": "If set, the $(ref:windows.Window) returned will be filtered based on its type. If unset the default filter is set to <code>['app', 'normal', 'panel', 'popup']</code>, with <code>'app'</code> and <code>'panel'</code> window types limited to the extension's own windows."
+              }
             }
           },
           {
             "type": "function",
             "name": "callback",
             "parameters": [
               {
-                "name": "window", "$ref": "Window"
+                "name": "window",
+                "$ref": "Window"
               }
             ]
           }
         ]
       },
       {
         "name": "getAll",
         "type": "function",
         "description": "Gets all windows.",
+        "async": "callback",
         "parameters": [
           {
             "type": "object",
             "name": "getInfo",
             "optional": true,
             "description": "",
             "properties": {
-              "populate": {"type": "boolean", "optional": true, "description": "If true, each $(ref:windows.Window) object will have a <var>tabs</var> property that contains a list of the $(ref:tabs.Tab) objects for that window. The <code>Tab</code> objects only contain the <code>url</code>, <code>title</code> and <code>favIconUrl</code> properties if the extension's manifest file includes the <code>\"tabs\"</code> permission." },
-              "windowTypes": {"type": "array", "items": { "$ref": "WindowType" }, "optional": true, "description": "If set, the $(ref:windows.Window) returned will be filtered based on its type. If unset the default filter is set to <code>['app', 'normal', 'panel', 'popup']</code>, with <code>'app'</code> and <code>'panel'</code> window types limited to the extension's own windows." }
+              "populate": {
+                "type": "boolean",
+                "optional": true,
+                "description": "If true, each $(ref:windows.Window) object will have a <var>tabs</var> property that contains a list of the $(ref:tabs.Tab) objects for that window. The <code>Tab</code> objects only contain the <code>url</code>, <code>title</code> and <code>favIconUrl</code> properties if the extension's manifest file includes the <code>\"tabs\"</code> permission."
+              },
+              "windowTypes": {
+                "type": "array",
+                "items": { "$ref": "WindowType" },
+                "optional": true,
+                "description": "If set, the $(ref:windows.Window) returned will be filtered based on its type. If unset the default filter is set to <code>['app', 'normal', 'panel', 'popup']</code>, with <code>'app'</code> and <code>'panel'</code> window types limited to the extension's own windows."
+              }
             }
           },
           {
             "type": "function",
             "name": "callback",
             "parameters": [
               {
-                "name": "windows", "type": "array", "items": { "$ref": "Window" }
+                "name": "windows",
+                "type": "array",
+                "items": { "$ref": "Window" }
               }
             ]
           }
         ]
       },
       {
         "name": "create",
         "type": "function",
         "description": "Creates (opens) a new browser with any optional sizing, position or default URL provided.",
+        "async": "callback",
         "parameters": [
           {
             "type": "object",
             "name": "createData",
             "properties": {
               "url": {
                 "description": "A URL or array of URLs to open as tabs in the window. Fully-qualified URLs must include a scheme (i.e. 'http://www.google.com', not 'www.google.com'). Relative URLs will be relative to the current page within the extension. Defaults to the New Tab Page.",
                 "optional": true,
                 "choices": [
-                  {"type": "string"},
-                  {"type": "array", "items": {"type": "string"}}
+                  { "type": "string" },
+                  {
+                    "type": "array",
+                    "items": { "type": "string" }
+                  }
                 ]
               },
-              "tabId": {"type": "integer", "minimum": 0, "optional": true, "description": "The id of the tab for which you want to adopt to the new window."},
-              "left": {"type": "integer", "optional": true, "description": "The number of pixels to position the new window from the left edge of the screen. If not specified, the new window is offset naturally from the last focused window. This value is ignored for panels."},
-              "top": {"type": "integer", "optional": true, "description": "The number of pixels to position the new window from the top edge of the screen. If not specified, the new window is offset naturally from the last focused window. This value is ignored for panels."},
-              "width": {"type": "integer", "minimum": 0, "optional": true, "description": "The width in pixels of the new window, including the frame. If not specified defaults to a natural width."},
-              "height": {"type": "integer", "minimum": 0, "optional": true, "description": "The height in pixels of the new window, including the frame. If not specified defaults to a natural height."},
-              "focused": {"unsupported": true, "type": "boolean", "optional": true, "description": "If true, opens an active window. If false, opens an inactive window."},
-              "incognito": {"type": "boolean", "optional": true, "description": "Whether the new window should be an incognito window."},
+              "tabId": {
+                "type": "integer",
+                "minimum": 0,
+                "optional": true,
+                "description": "The id of the tab for which you want to adopt to the new window."
+              },
+              "left": {
+                "type": "integer",
+                "optional": true,
+                "description": "The number of pixels to position the new window from the left edge of the screen. If not specified, the new window is offset naturally from the last focused window. This value is ignored for panels."
+              },
+              "top": {
+                "type": "integer",
+                "optional": true,
+                "description": "The number of pixels to position the new window from the top edge of the screen. If not specified, the new window is offset naturally from the last focused window. This value is ignored for panels."
+              },
+              "width": {
+                "type": "integer",
+                "minimum": 0,
+                "optional": true,
+                "description": "The width in pixels of the new window, including the frame. If not specified defaults to a natural width."
+              },
+              "height": {
+                "type": "integer",
+                "minimum": 0,
+                "optional": true,
+                "description": "The height in pixels of the new window, including the frame. If not specified defaults to a natural height."
+              },
+              "focused": {
+                "unsupported": true,
+                "type": "boolean",
+                "optional": true,
+                "description": "If true, opens an active window. If false, opens an inactive window."
+              },
+              "incognito": {
+                "type": "boolean",
+                "optional": true,
+                "description": "Whether the new window should be an incognito window."
+              },
               "type": {
                 "unsupported": true,
                 "$ref": "CreateType",
                 "optional": true,
                 "description": "Specifies what type of browser window to create. The 'panel' and 'detached_panel' types create a popup unless the '--enable-panels' flag is set."
               },
               "state": {
                 "unsupported": true,
@@ -222,66 +350,115 @@
             "optional": true
           },
           {
             "type": "function",
             "name": "callback",
             "optional": true,
             "parameters": [
               {
-                "name": "window", "$ref": "Window", "description": "Contains details about the created window.",
+                "name": "window",
+                "$ref": "Window",
+                "description": "Contains details about the created window.",
                 "optional": true
               }
             ]
           }
         ]
       },
       {
         "name": "update",
         "type": "function",
         "description": "Updates the properties of a window. Specify only the properties that you want to change; unspecified properties will be left unchanged.",
+        "async": "callback",
         "parameters": [
-          {"type": "integer", "name": "windowId", "minimum": -2},
+          {
+            "type": "integer",
+            "name": "windowId",
+            "minimum": -2
+          },
           {
             "type": "object",
             "name": "updateInfo",
             "properties": {
-              "left": {"unsupported": true, "type": "integer", "optional": true, "description": "The offset from the left edge of the screen to move the window to in pixels. This value is ignored for panels."},
-              "top": {"unsupported": true, "type": "integer", "optional": true, "description": "The offset from the top edge of the screen to move the window to in pixels. This value is ignored for panels."},
-              "width": {"unsupported": true, "type": "integer", "minimum": 0, "optional": true, "description": "The width to resize the window to in pixels. This value is ignored for panels."},
-              "height": {"unsupported": true, "type": "integer", "minimum": 0, "optional": true, "description": "The height to resize the window to in pixels. This value is ignored for panels."},
-              "focused": {"type": "boolean", "optional": true, "description": "If true, brings the window to the front. If false, brings the next window in the z-order to the front."},
-              "drawAttention": {"unsupported": true, "type": "boolean", "optional": true, "description": "If true, causes the window to be displayed in a manner that draws the user's attention to the window, without changing the focused window. The effect lasts until the user changes focus to the window. This option has no effect if the window already has focus. Set to false to cancel a previous draw attention request."},
+              "left": {
+                "unsupported": true,
+                "type": "integer",
+                "optional": true,
+                "description": "The offset from the left edge of the screen to move the window to in pixels. This value is ignored for panels."
+              },
+              "top": {
+                "unsupported": true,
+                "type": "integer",
+                "optional": true,
+                "description": "The offset from the top edge of the screen to move the window to in pixels. This value is ignored for panels."
+              },
+              "width": {
+                "unsupported": true,
+                "type": "integer",
+                "minimum": 0,
+                "optional": true,
+                "description": "The width to resize the window to in pixels. This value is ignored for panels."
+              },
+              "height": {
+                "unsupported": true,
+                "type": "integer",
+                "minimum": 0,
+                "optional": true,
+                "description": "The height to resize the window to in pixels. This value is ignored for panels."
+              },
+              "focused": {
+                "type": "boolean",
+                "optional": true,
+                "description": "If true, brings the window to the front. If false, brings the next window in the z-order to the front."
+              },
+              "drawAttention": {
+                "unsupported": true,
+                "type": "boolean",
+                "optional": true,
+                "description": "If true, causes the window to be displayed in a manner that draws the user's attention to the window, without changing the focused window. The effect lasts until the user changes focus to the window. This option has no effect if the window already has focus. Set to false to cancel a previous draw attention request."
+              },
               "state": {
                 "unsupported": true,
                 "$ref": "WindowState",
                 "optional": true,
                 "description": "The new state of the window. The 'minimized', 'maximized' and 'fullscreen' states cannot be combined with 'left', 'top', 'width' or 'height'."
               }
             }
           },
           {
             "type": "function",
             "name": "callback",
             "optional": true,
             "parameters": [
               {
-                "name": "window", "$ref": "Window"
+                "name": "window",
+                "$ref": "Window"
               }
             ]
           }
         ]
       },
       {
         "name": "remove",
         "type": "function",
         "description": "Removes (closes) a window, and all the tabs inside it.",
+        "async": "callback",
         "parameters": [
-          {"type": "integer", "name": "windowId", "minimum": 0},
-          {"type": "function", "name": "callback", "optional": true, "parameters": []}
+          {
+            "type": "integer",
+            "name": "windowId",
+            "minimum": 0
+          },
+          {
+            "type": "function",
+            "name": "callback",
+            "optional": true,
+            "parameters": []
+          }
         ]
       }
     ],
     "events": [
       {
         "name": "onCreated",
         "type": "function",
         "description": "Fired when a window is created.",
@@ -309,30 +486,40 @@
           {
             "name": "windowTypes",
             "type": "array",
             "items": { "$ref": "WindowType" },
             "description": "Conditions that the window's type being removed must satisfy. By default it will satisfy <code>['app', 'normal', 'panel', 'popup']</code>, with <code>'app'</code> and <code>'panel'</code> window types limited to the extension's own windows."
           }
         ],
         "parameters": [
-          {"type": "integer", "name": "windowId", "minimum": 0, "description": "ID of the removed window."}
+          {
+            "type": "integer",
+            "name": "windowId",
+            "minimum": 0,
+            "description": "ID of the removed window."
+          }
         ]
       },
       {
         "name": "onFocusChanged",
         "type": "function",
         "description": "Fired when the currently focused window changes. Will be $(ref:windows.WINDOW_ID_NONE) if all browser windows have lost focus. Note: On some Linux window managers, WINDOW_ID_NONE will always be sent immediately preceding a switch from one browser window to another.",
         "filters": [
           {
             "name": "windowTypes",
             "type": "array",
             "items": { "$ref": "WindowType" },
             "description": "Conditions that the window's type being removed must satisfy. By default it will satisfy <code>['app', 'normal', 'panel', 'popup']</code>, with <code>'app'</code> and <code>'panel'</code> window types limited to the extension's own windows."
           }
         ],
         "parameters": [
-          {"type": "integer", "name": "windowId", "minimum": -1, "description": "ID of the newly focused window."}
+          {
+            "type": "integer",
+            "name": "windowId",
+            "minimum": -1,
+            "description": "ID of the newly focused window."
+          }
         ]
       }
     ]
   }
 ]