Bug 1244304 - Remove unused appId / inBrowser from permission manager. r=ehsan draft
authorJ. Ryan Stinnett <jryans@gmail.com>
Fri, 29 Jan 2016 17:13:19 -0600
changeset 327259 2559198589e121d0d2d07b3d36dc875485ad6485
parent 327253 aeacd77c05b5fb875aca12ba2d100f1a8bd5bc38
child 513678 81c76e00a547a1045c10fdb4ba4ae1793c3cfe21
push id10217
push userjryans@gmail.com
push dateSat, 30 Jan 2016 00:37:07 +0000
reviewersehsan
bugs1244304
milestone47.0a1
Bug 1244304 - Remove unused appId / inBrowser from permission manager. r=ehsan
extensions/cookie/nsPermissionManager.cpp
--- a/extensions/cookie/nsPermissionManager.cpp
+++ b/extensions/cookie/nsPermissionManager.cpp
@@ -1768,24 +1768,16 @@ nsPermissionManager::AddInternal(nsIPrin
       entry->GetPermissions()[index].mID = id;
       entry->GetPermissions()[index].mPermission = aPermission;
       entry->GetPermissions()[index].mExpireType = aExpireType;
       entry->GetPermissions()[index].mExpireTime = aExpireTime;
       entry->GetPermissions()[index].mModificationTime = aModificationTime;
 
       // If requested, create the entry in the DB.
       if (aDBOperation == eWriteToDB) {
-        uint32_t appId;
-        rv = aPrincipal->GetAppId(&appId);
-        NS_ENSURE_SUCCESS(rv, rv);
-
-        bool isInBrowserElement;
-        rv = aPrincipal->GetIsInBrowserElement(&isInBrowserElement);
-        NS_ENSURE_SUCCESS(rv, rv);
-
         UpdateDB(eOperationAdding, mStmtInsert, id, origin, aType, aPermission,
                  aExpireType, aExpireTime, aModificationTime);
       }
 
       if (aNotifyOperation == eNotify) {
         NotifyObserversWithPermission(aPrincipal,
                                       mTypeArray[typeIndex],
                                       aPermission,
@@ -2947,9 +2939,8 @@ nsPermissionManager::FetchPermissions() 
     // will end up as now()) is fine.
     uint64_t modificationTime = 0;
     AddInternal(principal, perm.type, perm.capability, 0, perm.expireType,
                 perm.expireTime, modificationTime, eNotify, eNoDBOperation,
                 true /* ignoreSessionPermissions */);
   }
   return NS_OK;
 }
-