Bug 1234629 - Post: Make bouncer APK Java package org.mozilla.gecko, like the main APK. r=me draft
authorNick Alexander <nalexander@mozilla.com>
Wed, 27 Jan 2016 15:28:12 -0800
changeset 326429 ee60d4402d4222db604df7de525157da511f4f6f
parent 326428 819d041ea39212963ddbdd8c3dc8f46b34dc2cb0
child 513612 d1b5220f2772b1c33938239e0b8a3b5f148c6e23
push id10152
push usernalexander@mozilla.com
push dateWed, 27 Jan 2016 23:52:39 +0000
reviewersme
bugs1234629, 1242213
milestone47.0a1
Bug 1234629 - Post: Make bouncer APK Java package org.mozilla.gecko, like the main APK. r=me This small change is a follow-up to Bug 1242213, which did the same for the main package. This is a nod to the future and Gradle, which cleanly splits the internal Java package (org.mozilla.gecko) from the external Android package (org.mozilla.fennec and friends).
config/makefiles/java-build.mk
mobile/android/bouncer/AndroidManifest.xml.in
--- a/config/makefiles/java-build.mk
+++ b/config/makefiles/java-build.mk
@@ -74,16 +74,17 @@ android_res_files := $(wildcard $(addsuf
 )
 
 # aapt flag -m: 'make package directories under location specified by -J'.
 # The --extra-package list is colon separated.
 .aapt.deps: $(android_manifest) $(android_res_files) $(wildcard $(ANDROID_ASSETS_DIRS))
 	@$(TOUCH) $@
 	$(AAPT) package -f -M $< -I $(ANDROID_SDK)/android.jar $(_ANDROID_RES_FLAG) $(_ANDROID_ASSETS_FLAG) \
 		--custom-package $(ANDROID_APK_PACKAGE) \
+		--rename-manifest-package $(ANDROID_APK_PACKAGE) \
 		--non-constant-id \
 		--auto-add-overlay \
 		$(if $(ANDROID_EXTRA_PACKAGES),--extra-packages $(subst $(NULL) ,:,$(strip $(ANDROID_EXTRA_PACKAGES)))) \
 		$(if $(ANDROID_EXTRA_RES_DIRS),$(addprefix -S ,$(ANDROID_EXTRA_RES_DIRS))) \
 		-m \
 		-J ${@D}/generated \
 		-F $(ANDROID_APK_NAME).ap_
 
--- a/mobile/android/bouncer/AndroidManifest.xml.in
+++ b/mobile/android/bouncer/AndroidManifest.xml.in
@@ -1,12 +1,12 @@
 #filter substitution
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-      package="@ANDROID_PACKAGE_NAME@"
+      package="org.mozilla.gecko"
       android:installLocation="auto"
       android:versionCode="@ANDROID_VERSION_CODE@"
       android:versionName="@MOZ_APP_VERSION@"
 #ifdef MOZ_ANDROID_SHARED_ID
       android:sharedUserId="@MOZ_ANDROID_SHARED_ID@"
 #endif
       >
     <uses-sdk android:minSdkVersion="@MOZ_ANDROID_MIN_SDK_VERSION@"