Bug 1239376 - Enable StrictMode penaltyDeath on developer local & nightly builds. r=mfinkle draft
authorMichael Comella <michael.l.comella@gmail.com>
Wed, 27 Jan 2016 11:36:41 -0800
changeset 326272 2000032303be40a20eecbec2e1e3336f2cfc0d35
parent 326271 faa74a9297c8476f965a5f9268d5b9095458dd2b
child 513581 c97664d74a38247a0c9cf841cfa43b08739f932e
push id10128
push usermichael.l.comella@gmail.com
push dateWed, 27 Jan 2016 20:23:48 +0000
reviewersmfinkle
bugs1239376
milestone46.0a1
Bug 1239376 - Enable StrictMode penaltyDeath on developer local & nightly builds. r=mfinkle
mobile/android/base/java/org/mozilla/gecko/GeckoApp.java
--- a/mobile/android/base/java/org/mozilla/gecko/GeckoApp.java
+++ b/mobile/android/base/java/org/mozilla/gecko/GeckoApp.java
@@ -1152,18 +1152,19 @@ public abstract class GeckoApp
      *
      * Here we initialize all of our profile settings, Firefox Health Report,
      * and other one-shot constructions.
      **/
     @Override
     public void onCreate(Bundle savedInstanceState) {
         GeckoAppShell.ensureCrashHandling();
 
-        // Enable Android Strict Mode for developers' local builds (the "default" channel).
-        if ("default".equals(AppConstants.MOZ_UPDATE_CHANNEL)) {
+        // Enable Android Strict Mode for developers' local builds (the "default" channel) & Nightly.
+        if ("default".equals(AppConstants.MOZ_UPDATE_CHANNEL) ||
+                "nightly".equals(AppConstants.MOZ_UPDATE_CHANNEL)) {
             enableStrictMode();
         }
 
         if (!isSupportedSystem()) {
             // This build does not support the Android version of the device: Show an error and finish the app.
             super.onCreate(savedInstanceState);
             showSDKVersionError();
             finish();
@@ -1814,22 +1815,22 @@ public abstract class GeckoApp
      * Enable Android StrictMode checks (for supported OS versions).
      * http://developer.android.com/reference/android/os/StrictMode.html
      */
     private void enableStrictMode() {
         Log.d(LOGTAG, "Enabling Android StrictMode");
 
         StrictMode.setThreadPolicy(new StrictMode.ThreadPolicy.Builder()
                                   .detectAll()
-                                  .penaltyLog()
+                                  .penaltyDeath()
                                   .build());
 
         StrictMode.setVmPolicy(new StrictMode.VmPolicy.Builder()
                                .detectAll()
-                               .penaltyLog()
+                               .penaltyDeath()
                                .build());
     }
 
     @Override
     public void enableCameraView() {
         // Start listening for orientation events
         mCameraOrientationEventListener = new OrientationEventListener(this) {
             @Override