Bug 1241735 - Convert browser_webconsole_bug_614793_jsterm_scroll to be more e10s friendly;r=linclark draft
authorBrian Grinstead <bgrinstead@mozilla.com>
Thu, 21 Jan 2016 19:15:20 -0800
changeset 324154 5b225771ee4cae927421d82930621bd90836c077
parent 324153 1aed451f1502dc6437d172c6a3e87f36a2a64bcc
child 513335 f3d3cc005f850483467b7ae54ff03043b3e511d5
push id9856
push userbgrinstead@mozilla.com
push dateFri, 22 Jan 2016 03:16:32 +0000
reviewerslinclark
bugs1241735
milestone46.0a1
Bug 1241735 - Convert browser_webconsole_bug_614793_jsterm_scroll to be more e10s friendly;r=linclark
devtools/client/webconsole/test/browser_webconsole_bug_614793_jsterm_scroll.js
--- a/devtools/client/webconsole/test/browser_webconsole_bug_614793_jsterm_scroll.js
+++ b/devtools/client/webconsole/test/browser_webconsole_bug_614793_jsterm_scroll.js
@@ -1,65 +1,53 @@
 /* vim:set ts=2 sw=2 sts=2 et: */
 /*
  * Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/
- *
- * Contributor(s):
- *   Mihai Șucan <mihai.sucan@gmail.com>
  */
 
 "use strict";
 
 const TEST_URI = "data:text/html;charset=utf-8,Web Console test for " +
                  "bug 614793: jsterm result scroll";
 
-"use strict";
-
 add_task(function* () {
   yield loadTab(TEST_URI);
-
   let hud = yield openConsole();
 
-  yield consoleOpened(hud);
+  yield testScrollPosition(hud);
 });
 
-function consoleOpened(hud) {
-  let deferred = promise.defer();
-
+function* testScrollPosition(hud) {
   hud.jsterm.clearOutput();
 
   let scrollNode = hud.ui.outputWrapper;
 
   for (let i = 0; i < 150; i++) {
-    content.console.log("test message " + i);
+    yield ContentTask.spawn(gBrowser.selectedBrowser, i, function*(i) {
+      content.console.log("test message " + i);
+    });
   }
 
   let oldScrollTop = -1;
 
-  waitForMessages({
+  yield waitForMessages({
     webconsole: hud,
     messages: [{
       text: "test message 149",
       category: CATEGORY_WEBDEV,
       severity: SEVERITY_LOG,
     }],
-  }).then(() => {
-    oldScrollTop = scrollNode.scrollTop;
-    isnot(oldScrollTop, 0, "scroll location is not at the top");
-
-    hud.jsterm.execute("'hello world'").then(onExecute);
   });
 
-  function onExecute(msg) {
-    isnot(scrollNode.scrollTop, oldScrollTop, "scroll location updated");
+  oldScrollTop = scrollNode.scrollTop;
+  isnot(oldScrollTop, 0, "scroll location is not at the top");
 
-    oldScrollTop = scrollNode.scrollTop;
+  let msg = yield hud.jsterm.execute("'hello world'");
 
-    msg.scrollIntoView(false);
+  isnot(scrollNode.scrollTop, oldScrollTop, "scroll location updated");
 
-    is(scrollNode.scrollTop, oldScrollTop, "scroll location is the same");
+  oldScrollTop = scrollNode.scrollTop;
 
-    deferred.resolve();
-  }
+  msg.scrollIntoView(false);
 
-  return deferred.promise;
+  is(scrollNode.scrollTop, oldScrollTop, "scroll location is the same");
 }