Bug 1241278 - Record telemetry for notification permission callback usage. r?vladan draft
authorKit Cambridge <kcambridge@mozilla.com>
Thu, 21 Jan 2016 09:37:53 -0800
changeset 326016 c82aea4042bfadacd64357bd99e946ae435c8d18
parent 325488 bd8bb6298d90770f97843e9d7dc711cc0f87d02f
child 513532 e96f94962b31dd3b3f88bc0e9408591f22be7c3f
push id10074
push userkcambridge@mozilla.com
push dateTue, 26 Jan 2016 23:21:41 +0000
reviewersvladan
bugs1241278
milestone47.0a1
Bug 1241278 - Record telemetry for notification permission callback usage. r?vladan
dom/notification/Notification.cpp
toolkit/components/telemetry/Histograms.json
--- a/dom/notification/Notification.cpp
+++ b/dom/notification/Notification.cpp
@@ -651,16 +651,18 @@ nsresult
 NotificationPermissionRequest::ResolvePromise()
 {
   nsresult rv = NS_OK;
   if (mCallback) {
     ErrorResult error;
     mCallback->Call(mPermission, error);
     rv = error.StealNSResult();
   }
+  Telemetry::Accumulate(
+    Telemetry::WEB_NOTIFICATION_REQUEST_PERMISSION_CALLBACK, !!mCallback);
   mPromise->MaybeResolve(mPermission);
   return rv;
 }
 
 NS_IMETHODIMP
 NotificationPermissionRequest::GetTypes(nsIArray** aTypes)
 {
   nsTArray<nsString> emptyOptions;
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -10052,10 +10052,17 @@
   },
   "PLUGIN_DRAWING_MODEL": {
     "alert_emails": ["danderson@mozilla.com"],
     "expires_in_version": "never",
     "kind": "enumerated",
     "bug_numbers": [1229961],
     "n_values": 12,
     "description": "Plugin drawing model. 0 when windowed, otherwise NPDrawingModel + 1."
+  },
+  "WEB_NOTIFICATION_REQUEST_PERMISSION_CALLBACK": {
+    "alert_emails": ["push@mozilla.com"],
+    "expires_in_version": "55",
+    "bug_numbers": [1241278],
+    "kind": "boolean",
+    "description": "Usage of the deprecated Notification.requestPermission() callback argument"
   }
 }