Bug 1037618: Extend DNS timeout for bogus STUN server tests. draft
authorByron Campen [:bwc] <docfaraday@gmail.com>
Tue, 19 Jan 2016 10:50:08 -0600
changeset 322724 d211660876d70700b65d34484acd99e13f45ae50
parent 322694 b67316254602a63bf4e568198a5c7d3288a9db27
child 513162 0f5c632bd2aae1e17bd8c19ce1d5f75808c5d9c6
push id9666
push userbcampen@mozilla.com
push dateTue, 19 Jan 2016 16:50:32 +0000
bugs1037618
milestone46.0a1
Bug 1037618: Extend DNS timeout for bogus STUN server tests.
media/mtransport/test/ice_unittest.cpp
--- a/media/mtransport/test/ice_unittest.cpp
+++ b/media/mtransport/test/ice_unittest.cpp
@@ -1833,16 +1833,20 @@ TEST_F(IceGatherTest, TestGatherDNSStunS
   peer_->SetStunServer(g_stun_server_hostname, kDefaultStunServerPort);
   peer_->SetDNSResolver();
   Gather();
   ASSERT_TRUE(StreamHasMatchingCandidate(0, " UDP "));
   ASSERT_TRUE(StreamHasMatchingCandidate(0, "typ srflx raddr"));
 }
 
 TEST_F(IceGatherTest, TestGatherDNSStunServerHostnameTcp) {
+  if (g_stun_server_hostname.empty()) {
+    return;
+  }
+
   EnsurePeer(ICE_TEST_PEER_OFFERER | ICE_TEST_PEER_ENABLED_TCP);
   peer_->SetStunServer(g_stun_server_hostname, kDefaultStunServerPort,
     kNrIceTransportTcp);
   peer_->SetDNSResolver();
   Gather();
   ASSERT_TRUE(StreamHasMatchingCandidate(0, "tcptype passive"));
   ASSERT_FALSE(StreamHasMatchingCandidate(0, "tcptype passive", " 9 "));
   ASSERT_TRUE(StreamHasMatchingCandidate(0, "tcptype so"));
@@ -1887,26 +1891,26 @@ TEST_F(IceGatherTest, TestGatherDNSStunS
   ASSERT_TRUE(StreamHasMatchingCandidate(0, " UDP "));
   ASSERT_TRUE(StreamHasMatchingCandidate(0, " TCP "));
 }
 
 TEST_F(IceGatherTest, TestGatherDNSStunBogusHostname) {
   EnsurePeer();
   peer_->SetStunServer(kBogusStunServerHostname, kDefaultStunServerPort);
   peer_->SetDNSResolver();
-  Gather();
+  Gather(3 * kDefaultTimeout);
   ASSERT_TRUE(StreamHasMatchingCandidate(0, " UDP "));
 }
 
 TEST_F(IceGatherTest, TestGatherDNSStunBogusHostnameTcp) {
   EnsurePeer(ICE_TEST_PEER_OFFERER | ICE_TEST_PEER_ENABLED_TCP);
   peer_->SetStunServer(kBogusStunServerHostname, kDefaultStunServerPort,
     kNrIceTransportTcp);
   peer_->SetDNSResolver();
-  Gather();
+  Gather(3 * kDefaultTimeout);
   ASSERT_TRUE(StreamHasMatchingCandidate(0, " TCP "));
 }
 
 TEST_F(IceGatherTest, TestDefaultCandidate) {
   EnsurePeer();
   peer_->SetStunServer(g_stun_server_hostname, kDefaultStunServerPort);
   Gather();
   NrIceCandidate default_candidate;