Bug 1240479 - pass values for mReversePortion and mStartForReversingTestin through constructor. r?heycam draft
authorBogdan Postelnicu <bogdan.postelnicu@softvision.ro>
Tue, 19 Jan 2016 12:33:56 +0200
changeset 322638 8d73b988adb7a0138aba19e803b29ed93b4b9c1c
parent 322386 a77b73c7723e1060993045fb31eb2f0a30473486
child 513140 98ed5c89cc23d98c634d47e2b0721e4f947c2f9d
push id9644
push userbmo:bogdan.postelnicu@softvision.ro
push dateTue, 19 Jan 2016 10:44:12 +0000
reviewersheycam
bugs1240479
milestone46.0a1
Bug 1240479 - pass values for mReversePortion and mStartForReversingTestin through constructor. r?heycam
layout/style/nsTransitionManager.cpp
layout/style/nsTransitionManager.h
--- a/layout/style/nsTransitionManager.cpp
+++ b/layout/style/nsTransitionManager.cpp
@@ -652,19 +652,18 @@ nsTransitionManager::ConsiderStartingTra
   timing.mDuration.SetAsUnrestrictedDouble() = duration;
   timing.mDelay = TimeDuration::FromMilliseconds(delay);
   timing.mIterations = 1.0;
   timing.mDirection = dom::PlaybackDirection::Normal;
   timing.mFill = dom::FillMode::Backwards;
 
   RefPtr<ElementPropertyTransition> pt =
     new ElementPropertyTransition(aElement->OwnerDoc(), aElement,
-                                  aNewStyleContext->GetPseudoType(), timing);
-  pt->mStartForReversingTest = startForReversingTest;
-  pt->mReversePortion = reversePortion;
+                                  aNewStyleContext->GetPseudoType(), timing,
+                                  startForReversingTest, reversePortion);
 
   AnimationProperty& prop = *pt->Properties().AppendElement();
   prop.mProperty = aProperty;
 
   AnimationPropertySegment& segment = *prop.mSegments.AppendElement();
   segment.mFromValue = startValue;
   segment.mToValue = endValue;
   segment.mFromKey = 0;
--- a/layout/style/nsTransitionManager.h
+++ b/layout/style/nsTransitionManager.h
@@ -33,18 +33,22 @@ struct StyleTransition;
 
 namespace mozilla {
 
 struct ElementPropertyTransition : public dom::KeyframeEffectReadOnly
 {
   ElementPropertyTransition(nsIDocument* aDocument,
                             dom::Element* aTarget,
                             nsCSSPseudoElements::Type aPseudoType,
-                            const TimingParams &aTiming)
+                            const TimingParams &aTiming,
+                            StyleAnimationValue aStartForReversingTest,
+                            double aReversePortion)
     : dom::KeyframeEffectReadOnly(aDocument, aTarget, aPseudoType, aTiming)
+    , mStartForReversingTest(aStartForReversingTest)
+    , mReversePortion(aReversePortion)
   { }
 
   ElementPropertyTransition* AsTransition() override { return this; }
   const ElementPropertyTransition* AsTransition() const override
   {
     return this;
   }