Bug 1239678 - fix dll inclusion pattern on Windows and the placement of nested dlls like browsercomps and clearkey, r?nalexander
--- a/python/mozbuild/mozbuild/artifacts.py
+++ b/python/mozbuild/mozbuild/artifacts.py
@@ -314,17 +314,17 @@ class MacArtifactJob(ArtifactJob):
pass
class WinArtifactJob(ArtifactJob):
package_artifact_patterns = {
'firefox/dependentlibs.list',
'firefox/platform.ini',
'firefox/application.ini',
- 'firefox/*.dll',
+ 'firefox/**/*.dll',
'firefox/*.exe',
}
# These are a subset of TEST_HARNESS_BINS in testing/mochitest/Makefile.in.
test_artifact_patterns = {
'bin/BadCertServer.exe',
'bin/GenerateOCSPResponse.exe',
'bin/OCSPStaplingServer.exe',
'bin/certutil.exe',
@@ -336,17 +336,18 @@ class WinArtifactJob(ArtifactJob):
def process_package_artifact(self, filename, processed_filename):
added_entry = False
with JarWriter(file=processed_filename, optimize=False, compress_level=5) as writer:
for f in JarReader(filename):
if not any(mozpath.match(f.filename, p) for p in self.package_artifact_patterns):
continue
- basename = mozpath.basename(f.filename)
+ # strip off the relative "firefox/" bit from the path:
+ basename = mozpath.relpath(f.filename, "firefox")
self.log(logging.INFO, 'artifact',
{'basename': basename},
'Adding {basename} to processed archive')
writer.add(basename.encode('utf-8'), f)
added_entry = True
if not added_entry:
raise ValueError('Archive format changed! No pattern from "{patterns}"'