Bug 1239363 - Accept non-string types for marionette.logging pref; r=AutomatedTester
The marionette.logging preference used to have a boolean type.
To maintain backwards compatibility with earlier clients we keep accepting
boolean types as input.
Previously setting it to true meant you wanted all the logs, and this
change respects that.
--- a/testing/marionette/components/marionettecomponent.js
+++ b/testing/marionette/components/marionettecomponent.js
@@ -57,19 +57,23 @@ MarionetteComponent.prototype.determineL
#ifdef DEBUG
level = Log.Level.Trace;
#endif
// marionette.logging pref can override default
// with an entry from the Log.Level enum
if (Preferences.has(LOG_PREF)) {
let s = Preferences.get(LOG_PREF);
- s = s.toLowerCase();
- s = s.charAt(0).toUpperCase() + s.slice(1);
- level = Log.Level[s];
+ if (typeof s == "string") {
+ s = s.toLowerCase();
+ s = s.charAt(0).toUpperCase() + s.slice(1);
+ level = Log.Level[s];
+ } else {
+ level = Log.Level.Trace;
+ }
}
return level;
};
MarionetteComponent.prototype.onSocketAccepted = function(
socket, transport) {
this.logger.info("onSocketAccepted for Marionette dummy socket");