Bug 1234153 - Hide block list feature behind Nightly flag. r?margaret
--- a/mobile/android/base/java/org/mozilla/gecko/restrictions/RestrictedProfileConfiguration.java
+++ b/mobile/android/base/java/org/mozilla/gecko/restrictions/RestrictedProfileConfiguration.java
@@ -11,16 +11,17 @@ import org.mozilla.gecko.util.ThreadUtil
import android.annotation.TargetApi;
import android.content.Context;
import android.os.Build;
import android.os.Bundle;
import android.os.StrictMode;
import android.os.UserManager;
+import java.util.ArrayList;
import java.util.Arrays;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
@TargetApi(Build.VERSION_CODES.JELLY_BEAN_MR2)
public class RestrictedProfileConfiguration implements RestrictionConfiguration {
// Mapping from restrictable feature to default state (on/off)
@@ -29,36 +30,37 @@ public class RestrictedProfileConfigurat
configuration.put(Restrictable.INSTALL_EXTENSION, false);
configuration.put(Restrictable.PRIVATE_BROWSING, false);
configuration.put(Restrictable.CLEAR_HISTORY, false);
configuration.put(Restrictable.MASTER_PASSWORD, false);
configuration.put(Restrictable.GUEST_BROWSING, false);
configuration.put(Restrictable.ADVANCED_SETTINGS, false);
configuration.put(Restrictable.CAMERA_MICROPHONE, false);
configuration.put(Restrictable.DATA_CHOICES, false);
-
- // Hold behind Nightly flag until we have an actual block list deployed.
- if (AppConstants.NIGHTLY_BUILD) {
- configuration.put(Restrictable.BLOCK_LIST, false);
- }
-
+ configuration.put(Restrictable.BLOCK_LIST, false);
configuration.put(Restrictable.TELEMETRY, false);
configuration.put(Restrictable.HEALTH_REPORT, true);
configuration.put(Restrictable.DEFAULT_THEME, true);
}
/**
* These restrictions are hidden from the admin configuration UI.
*/
- private static List<Restrictable> hiddenRestrictions = Arrays.asList(
- Restrictable.MASTER_PASSWORD,
- Restrictable.GUEST_BROWSING,
- Restrictable.DATA_CHOICES,
- Restrictable.DEFAULT_THEME
- );
+ private static List<Restrictable> hiddenRestrictions = new ArrayList<>();
+ static {
+ hiddenRestrictions.add(Restrictable.MASTER_PASSWORD);
+ hiddenRestrictions.add(Restrictable.GUEST_BROWSING);
+ hiddenRestrictions.add(Restrictable.DATA_CHOICES);
+ hiddenRestrictions.add(Restrictable.DEFAULT_THEME);
+
+ // Hold behind Nightly flag until we have an actual block list deployed.
+ if (!AppConstants.NIGHTLY_BUILD){
+ hiddenRestrictions.add(Restrictable.BLOCK_LIST);
+ }
+ }
/* package-private */ static boolean shouldHide(Restrictable restrictable) {
return hiddenRestrictions.contains(restrictable);
}
/* package-private */ static Map<Restrictable, Boolean> getConfiguration() {
return configuration;
}