Bug 1222747 - fix alignment of forward button on OSX devedition theme, r?dao draft
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Mon, 04 Jan 2016 15:51:31 +0000
changeset 319580 f310a2875b59e7de7d11ee72a40819f355fdc974
parent 319579 62cd41c5e180ce37ffb0f5c5669f0bb3ef1ced6f
child 512618 4d61d1b1b22ba9c28d2d6d001253de0e88eb306e
push id9059
push usergijskruitbosch@gmail.com
push dateThu, 07 Jan 2016 11:44:12 +0000
reviewersdao
bugs1222747
milestone46.0a1
Bug 1222747 - fix alignment of forward button on OSX devedition theme, r?dao
browser/themes/osx/devedition.css
--- a/browser/themes/osx/devedition.css
+++ b/browser/themes/osx/devedition.css
@@ -36,16 +36,28 @@
   height: 24px !important;
   box-shadow: none !important;
   border: 1px solid var(--chrome-nav-bar-controls-border-color) !important;
   background: var(--chrome-nav-buttons-background) !important;
 }
 
 #forward-button {
   -moz-border-start: none !important;
+  /* browser.css and friends set up the width of the button to be 32px.
+   * They then set margin-left to -2px to ensure the button is not too wide
+   * compared to the back button, and set padding-left to center the icon
+   * correctly.
+   * In our theme, the back and forward buttons are the same width, with the
+   * back button being 32px with 1px border on both sides. To ensure the
+   * forward button's content box looks like it is the same size with width
+   * set to 32px and a 1px border on only 1 side, we overlap by 1px, so both
+   * buttons end up with a content box that looks like it's 30px.
+   */
+  margin-left: -1px;
+  padding-left: 1px;
 }
 
 #forward-button > .toolbarbutton-icon {
   margin-left: 0;
   margin-right: 0;
 }
 
 #back-button:hover:not([disabled="true"]),