Bug 1233650. Part 4 - remove unused functions from DecodedStream. r=roc. draft
authorJW Wang <jwwang@mozilla.com>
Thu, 24 Dec 2015 10:14:16 +0800
changeset 317476 fefb801a8efaa45963f3f825cd8cf0ae4058acfb
parent 317475 faa4bd48d91c0163bb1b799589974edab7527f47
child 512300 47e137c359ec85e2f8037e446116c20c66519153
push id8701
push userjwwang@mozilla.com
push dateThu, 24 Dec 2015 02:14:36 +0000
reviewersroc
bugs1233650
milestone46.0a1
Bug 1233650. Part 4 - remove unused functions from DecodedStream. r=roc.
dom/media/MediaDecoderStateMachine.cpp
dom/media/mediasink/DecodedStream.cpp
dom/media/mediasink/DecodedStream.h
--- a/dom/media/MediaDecoderStateMachine.cpp
+++ b/dom/media/MediaDecoderStateMachine.cpp
@@ -2941,28 +2941,28 @@ uint32_t MediaDecoderStateMachine::GetAm
     : std::max<uint32_t>(sVideoQueueDefaultSize, MIN_VIDEO_QUEUE_SIZE);
 }
 
 void MediaDecoderStateMachine::AddOutputStream(ProcessedMediaStream* aStream,
                                                bool aFinishWhenEnded)
 {
   MOZ_ASSERT(NS_IsMainThread());
   DECODER_LOG("AddOutputStream aStream=%p!", aStream);
-  mStreamSink->AddOutput(aStream, aFinishWhenEnded);
+  mOutputStreamManager->Add(aStream, aFinishWhenEnded);
   nsCOMPtr<nsIRunnable> r = NS_NewRunnableMethodWithArg<bool>(
     this, &MediaDecoderStateMachine::SetAudioCaptured, true);
   OwnerThread()->Dispatch(r.forget());
 }
 
 void MediaDecoderStateMachine::RemoveOutputStream(MediaStream* aStream)
 {
   MOZ_ASSERT(NS_IsMainThread());
   DECODER_LOG("RemoveOutputStream=%p!", aStream);
-  mStreamSink->RemoveOutput(aStream);
-  if (!mStreamSink->HasConsumers()) {
+  mOutputStreamManager->Remove(aStream);
+  if (mOutputStreamManager->IsEmpty()) {
     nsCOMPtr<nsIRunnable> r = NS_NewRunnableMethodWithArg<bool>(
       this, &MediaDecoderStateMachine::SetAudioCaptured, false);
     OwnerThread()->Dispatch(r.forget());
   }
 }
 
 } // namespace mozilla
 
--- a/dom/media/mediasink/DecodedStream.cpp
+++ b/dom/media/mediasink/DecodedStream.cpp
@@ -370,22 +370,16 @@ DecodedStream::CreateData(MozPromiseHold
   };
 
   // Post a message to ensure |mData| is only updated on the worker thread.
   // Note this could fail when MDSM begin to shut down the worker thread.
   nsCOMPtr<nsIRunnable> r = new R(this, &DecodedStream::OnDataCreated, data);
   mOwnerThread->Dispatch(r.forget(), AbstractThread::DontAssertDispatchSuccess);
 }
 
-bool
-DecodedStream::HasConsumers() const
-{
-  return !mOutputStreamManager->IsEmpty();
-}
-
 void
 DecodedStream::OnDataCreated(UniquePtr<DecodedStreamData> aData)
 {
   AssertOwnerThread();
   MOZ_ASSERT(!mData, "Already created.");
 
   // Start to send data to the stream immediately
   if (mStartTime.isSome()) {
@@ -395,28 +389,16 @@ DecodedStream::OnDataCreated(UniquePtr<D
     return;
   }
 
   // Playback has ended. Destroy aData which is not needed anymore.
   DestroyData(Move(aData));
 }
 
 void
-DecodedStream::AddOutput(ProcessedMediaStream* aStream, bool aFinishWhenEnded)
-{
-  mOutputStreamManager->Add(aStream, aFinishWhenEnded);
-}
-
-void
-DecodedStream::RemoveOutput(MediaStream* aStream)
-{
-  mOutputStreamManager->Remove(aStream);
-}
-
-void
 DecodedStream::SetPlaying(bool aPlaying)
 {
   AssertOwnerThread();
 
   // Resume/pause matters only when playback started.
   if (mStartTime.isNothing()) {
     return;
   }
--- a/dom/media/mediasink/DecodedStream.h
+++ b/dom/media/mediasink/DecodedStream.h
@@ -56,20 +56,17 @@ public:
   void SetPlaying(bool aPlaying) override;
 
   void Start(int64_t aStartTime, const MediaInfo& aInfo) override;
   void Stop() override;
   bool IsStarted() const override;
   bool IsPlaying() const override;
 
   // TODO: fix these functions that don't fit into the interface of MediaSink.
-  void AddOutput(ProcessedMediaStream* aStream, bool aFinishWhenEnded);
-  void RemoveOutput(MediaStream* aStream);
   void SetSameOrigin(bool aSameOrigin);
-  bool HasConsumers() const;
 
 protected:
   virtual ~DecodedStream();
 
 private:
   void CreateData(MozPromiseHolder<GenericPromise>&& aPromise);
   void DestroyData(UniquePtr<DecodedStreamData> aData);
   void OnDataCreated(UniquePtr<DecodedStreamData> aData);