Bug 1469054 - ESLint: Use integer for the radix on parseInt. r?jdescottes draft
authorHiroyuki Ikezoe <hikezoe@mozilla.com>
Thu, 09 Aug 2018 14:27:56 +0900
changeset 827779 ab38cebf3f708abb54ce96003bd6fd98ea5f14f9
parent 827778 f641c9cafa7e3194d12c0b90c3819bac29f4bed3
child 827780 f084600d8f801dec28bc09f7e529ff690ea63e43
push id118583
push userhikezoe@mozilla.com
push dateThu, 09 Aug 2018 06:03:03 +0000
reviewersjdescottes
bugs1469054
milestone63.0a1
Bug 1469054 - ESLint: Use integer for the radix on parseInt. r?jdescottes I am not sure this had caused real issue though. MozReview-Commit-ID: ISSSJCYcpAm
devtools/shared/adb/adb-running-checker.js
--- a/devtools/shared/adb/adb-running-checker.js
+++ b/devtools/shared/adb/adb-running-checker.js
@@ -28,17 +28,17 @@ exports.check = async function check() {
           state = "wait-version";
           break;
         case "wait-version":
           // TODO: Actually check the version number to make sure the daemon
           //       supports the commands we want to use
           const { length, data } = client.unpackPacket(packetData);
           console.debug("length: ", length, "data: ", data);
           socket.close();
-          const version = parseInt(data, "16");
+          const version = parseInt(data, 16);
           if (version >= 31) {
             resolve(true);
           } else {
             console.log("killing existing adb as we need version >= 31");
             resolve(false);
           }
           break;
         default: