Bug 1325814 - Clarify file overview comment in ExtensionChild.jsm draft
authorRob Wu <rob@robwu.nl>
Thu, 02 Aug 2018 23:16:46 +0200
changeset 826911 e81474c6d1aee6f0175d3edc95b12228d967cac3
parent 826887 7a3737f257d51c78110bbab40017dbb593410518
child 826912 eb95226dea98cc0e47d46b5ad698a4cf5382da49
child 827545 fcda6b3f90d5f599d7629ddd388d781ad5bc8d8a
push id118407
push userbmo:rob@robwu.nl
push dateMon, 06 Aug 2018 09:39:47 +0000
bugs1325814, 1317697
milestone63.0a1
Bug 1325814 - Clarify file overview comment in ExtensionChild.jsm At its inception, ExtensionChild.jsm was meant to be used for the extension child process. Over time, this intent was not consistently followed, and in bug 1317697 this was fixed by splitting some logic in ExtensionChild.jsm off to ExtensionPageChild.jsm. Henceforth ExtensionChild.jsm handles logic that is common to all content processes, including web content and extension logic. Updated the comment at the top of the file to match this reality. MozReview-Commit-ID: 3cAd0FPj6Vz
toolkit/components/extensions/ExtensionChild.jsm
--- a/toolkit/components/extensions/ExtensionChild.jsm
+++ b/toolkit/components/extensions/ExtensionChild.jsm
@@ -4,20 +4,19 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 "use strict";
 
 /* exported ExtensionChild */
 
 var EXPORTED_SYMBOLS = ["ExtensionChild"];
 
-/*
- * This file handles addon logic that is independent of the chrome process.
- * When addons run out-of-process, this is the main entry point.
- * Its primary function is managing addon globals.
+/**
+ * This file handles addon logic that is independent of the chrome process and
+ * may run in all web content and extension processes.
  *
  * Don't put contentscript logic here, use ExtensionContent.jsm instead.
  */
 
 ChromeUtils.import("resource://gre/modules/Services.jsm");
 ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");
 
 XPCOMUtils.defineLazyServiceGetter(this, "finalizationService",