Bug 1475033 part 5 - Remove scrollbarbutton min-{width,height} rule. r?jimm draft
authorXidorn Quan <me@upsuper.org>
Mon, 06 Aug 2018 14:21:40 +1000
changeset 829853 fca30130adf22b3b3d42d1ef7058e3c0d804297b
parent 829852 dbbeb8f0719309c717281f9a496e0b90ab8d0766
child 829854 ee529ab5300d6b89de71bbfe8a14801ff2134c03
push id118798
push userxquan@mozilla.com
push dateFri, 17 Aug 2018 01:17:12 +0000
reviewersjimm
bugs1475033
milestone63.0a1
Bug 1475033 part 5 - Remove scrollbarbutton min-{width,height} rule. r?jimm Almost all widgets provide a non-overridable size for scrollbar buttons, so it makes no sense to specify min size for them. It is probably a layout bug that min size properties can override the value returned by GetMinimumWidgetSize even if aIsOverridable is set to false, but removing this rule is simpler than locating and fixing the issue in layout code :) MozReview-Commit-ID: 58pmxQaHlGe
toolkit/themes/windows/global/xulscrollbars.css
--- a/toolkit/themes/windows/global/xulscrollbars.css
+++ b/toolkit/themes/windows/global/xulscrollbars.css
@@ -48,23 +48,16 @@ thumb[orient="vertical"] {
   min-height: 8px;
 }
 
 thumb[orient="horizontal"] {
   -moz-appearance: scrollbarthumb-horizontal;
   min-width: 8px;
 }
 
-/* ::::: scrollbar button ::::: */
-
-scrollbarbutton {
-  min-width: 16px;
-  min-height: 16px;
-}
-
 /* ::::: square at the corner of two scrollbars ::::: */
 
 scrollcorner {
   -moz-appearance: scrollcorner;
   width: 16px;
   cursor: default;
   background-color: -moz-Dialog;
 }