Bug 1478549 - Allow user to configure android media autoplay pref. r=JanH
MozReview-Commit-ID: EPKzLrIc3lg
--- a/mobile/android/app/src/main/res/values/arrays.xml
+++ b/mobile/android/app/src/main/res/values/arrays.xml
@@ -142,9 +142,18 @@
<item>@string/pref_tap_to_load_images_data</item>
<item>@string/pref_tap_to_load_images_disabled2</item>
</string-array>
<string-array name="pref_browser_image_blocking_values">
<item>1</item> <!-- Always -->
<item>2</item> <!-- Wifi-only -->
<item>0</item> <!-- Blocked -->
</string-array>
+ <!-- media.autoplay.default -->
+ <string-array name="pref_media_autoplay_default_entries">
+ <item>@string/pref_media_autoplay_allow</item>
+ <item>@string/pref_media_autoplay_block</item>
+ </string-array>
+ <string-array name="pref_media_autoplay_default_values">
+ <item>0</item> <!-- Allowed -->
+ <item>1</item> <!-- Blocked -->
+ </string-array>
</resources>
--- a/mobile/android/app/src/main/res/xml/preferences_advanced.xml
+++ b/mobile/android/app/src/main/res/xml/preferences_advanced.xml
@@ -49,20 +49,21 @@
<SwitchPreference android:key="browser.display.use_document_fonts"
android:title="@string/pref_show_web_fonts"
android:summary="@string/pref_show_web_fonts_summary"/>
</PreferenceCategory>
<PreferenceCategory android:title="@string/pref_category_media">
- <SwitchPreference android:key="media.autoplay.default"
- android:title="@string/pref_media_autoplay_enabled"
- android:summary="@string/pref_media_autoplay_enabled_summary" />
-
+ <ListPreference android:key="media.autoplay.default"
+ android:title="@string/pref_media_autoplay_enabled"
+ android:entries="@array/pref_media_autoplay_default_entries"
+ android:entryValues="@array/pref_media_autoplay_default_values"
+ android:persistent="false" />
</PreferenceCategory>
<PreferenceCategory android:title="@string/pref_category_developer_tools">
<SwitchPreference android:key="devtools.remote.usb.enabled"
android:title="@string/pref_developer_remotedebugging_usb" />
<SwitchPreference android:key="devtools.remote.wifi.enabled"
--- a/mobile/android/base/locales/en-US/android_strings.dtd
+++ b/mobile/android/base/locales/en-US/android_strings.dtd
@@ -358,17 +358,18 @@
<!ENTITY pref_restore_quit "Don\'t restore after quitting &brandShortName;">
<!-- Localization note (pref_use_system_font_size, pref_use_system_font_size_summary):
Font size here refers to the name of the corresponding Android system setting. -->
<!ENTITY pref_use_system_font_size "Use system font size">
<!ENTITY pref_use_system_font_size_summary "Scale web content according to the system font size">
<!ENTITY pref_media_autoplay_enabled "Allow autoplay">
-<!ENTITY pref_media_autoplay_enabled_summary "Control if websites can autoplay videos and other media content">
+<!ENTITY pref_media_autoplay_allow "Allow autoplay">
+<!ENTITY pref_media_autoplay_block "Block autoplay">
<!ENTITY pref_zoom_force_enabled "Always enable zoom">
<!ENTITY pref_zoom_force_enabled_summary "Force override so you can zoom any page">
<!ENTITY pref_voice_input "Voice input">
<!ENTITY pref_voice_input_summary2 "Allow voice dictation in the URL bar">
<!ENTITY pref_qrcode_enabled "QR code reader">
<!ENTITY pref_qrcode_enabled_summary2 "Allow QR scanner in the URL bar">
<!ENTITY pref_use_master_password "Use master password">
--- a/mobile/android/base/strings.xml.in
+++ b/mobile/android/base/strings.xml.in
@@ -240,17 +240,18 @@
<string name="pref_clear_private_data_now">&pref_clear_private_data2;</string>
<string name="pref_clear_private_data_now_tablet">&pref_clear_private_data_now_tablet;</string>
<string name="pref_clear_on_exit_title">&pref_clear_on_exit_title3;</string>
<string name="pref_clear_on_exit_summary2">&pref_clear_on_exit_summary2;</string>
<string name="pref_clear_on_exit_dialog_title">&pref_clear_on_exit_dialog_title;</string>
<string name="pref_use_system_font_size">&pref_use_system_font_size;</string>
<string name="pref_use_system_font_size_summary">&pref_use_system_font_size_summary;</string>
<string name="pref_media_autoplay_enabled">&pref_media_autoplay_enabled;</string>
- <string name="pref_media_autoplay_enabled_summary">&pref_media_autoplay_enabled_summary;</string>
+ <string name="pref_media_autoplay_allow">&pref_media_autoplay_allow;</string>
+ <string name="pref_media_autoplay_block">&pref_media_autoplay_block;</string>
<string name="pref_zoom_force_enabled">&pref_zoom_force_enabled;</string>
<string name="pref_zoom_force_enabled_summary">&pref_zoom_force_enabled_summary;</string>
<string name="pref_voice_input">&pref_voice_input;</string>
<string name="pref_voice_input_summary">&pref_voice_input_summary2;</string>
<string name="pref_qrcode_enabled">&pref_qrcode_enabled;</string>
<string name="pref_qrcode_enabled_summary">&pref_qrcode_enabled_summary2;</string>
<string name="pref_restore">&pref_restore_tabs;</string>
<string name="pref_restore_always">&pref_restore_always;</string>