Bug 1476900 - Can't update Nightly from about:firefox or notification bar; r?sdaswani draft
authorPetru Lingurar <petru.lingurar@softvision.ro>
Tue, 24 Jul 2018 17:31:59 +0300
changeset 822015 7553f521384ecb02e5eb9d09e8d97ed938f74401
parent 821899 b5f79204032bfa3de2826e40c19b718fef404812
push id117253
push userplingurar@mozilla.com
push dateTue, 24 Jul 2018 14:34:45 +0000
reviewerssdaswani
bugs1476900
milestone63.0a1
Bug 1476900 - Can't update Nightly from about:firefox or notification bar; r?sdaswani The problem was because on API >=26 the JobIntentServices used for the updater functionality will be used by JobScheduler by binding to them. But because they were set to run in a different process the binding was not possible. MozReview-Commit-ID: I8rbcoLyhyJ
mobile/android/base/AndroidManifest.xml.in
--- a/mobile/android/base/AndroidManifest.xml.in
+++ b/mobile/android/base/AndroidManifest.xml.in
@@ -396,39 +396,35 @@
                   android:grantUriPermissions="true">
                   <meta-data android:name="android.support.FILE_PROVIDER_PATHS"
                              android:resource="@xml/provider_paths" />
         </provider>
 
         <service
             android:exported="false"
             android:name="org.mozilla.gecko.updater.UpdatesApplyService"
-            android:permission="android.permission.BIND_JOB_SERVICE"
-            android:process="@MANGLED_ANDROID_PACKAGE_NAME@.UpdateService">
+            android:permission="android.permission.BIND_JOB_SERVICE" >
         </service>
 
         <service
             android:exported="false"
             android:name="org.mozilla.gecko.updater.UpdatesCheckService"
-            android:permission="android.permission.BIND_JOB_SERVICE"
-            android:process="@MANGLED_ANDROID_PACKAGE_NAME@.UpdateService">
+            android:permission="android.permission.BIND_JOB_SERVICE" >
         </service>
 
         <service
             android:exported="false"
             android:name="org.mozilla.gecko.updater.UpdatesDownloadService"
-            android:permission="android.permission.BIND_JOB_SERVICE"
-            android:process="@MANGLED_ANDROID_PACKAGE_NAME@.UpdateService">
+            android:permission="android.permission.BIND_JOB_SERVICE" >
          </service>
 
         <service
             android:exported="false"
             android:name="org.mozilla.gecko.updater.UpdatesRegisterService"
-            android:permission="android.permission.BIND_JOB_SERVICE"
-            android:process="@MANGLED_ANDROID_PACKAGE_NAME@.UpdateService">
+            android:permission="android.permission.BIND_JOB_SERVICE" >
         </service>
 
         <receiver
             android:name="org.mozilla.gecko.updater.UpdateServiceReceiver"
             android:exported="false">
             <intent-filter>
                 <action android:name="@ANDROID_PACKAGE_NAME@.CHECK_FOR_UPDATE"></action>
                 <action android:name="@ANDROID_PACKAGE_NAME@.APPLY_UPDATE"></action>