Bug 1406533 - Remove hack for remote popup windows on Linux, r?karlt draft
authorMartin Stransky <stransky@redhat.com>
Tue, 24 Jul 2018 16:19:00 +0200
changeset 822014 70448700bc2213f4608d1971c14a4f2e1408d603
parent 822013 c0b33d51d8b13067f927094f9c3d922425960a99
push id117252
push userstransky@redhat.com
push dateTue, 24 Jul 2018 14:29:28 +0000
reviewerskarlt
bugs1406533, 630346
milestone63.0a1
Bug 1406533 - Remove hack for remote popup windows on Linux, r?karlt This hack was introduced at Bug 630346 and we should not need it any more. MozReview-Commit-ID: FsRLY9A1T5O
layout/xul/nsMenuPopupFrame.cpp
--- a/layout/xul/nsMenuPopupFrame.cpp
+++ b/layout/xul/nsMenuPopupFrame.cpp
@@ -301,27 +301,16 @@ nsMenuPopupFrame::CreateWidgetForView(ns
           static_cast<enum nsBorderStyle>(widgetData.mBorderStyle | eBorderStyle_close);
       }
     }
   }
 
   bool remote = HasRemoteContent();
 
   nsTransparencyMode mode = nsLayoutUtils::GetFrameTransparency(this, this);
-#ifdef MOZ_WIDGET_GTK
-  if (remote) {
-    // Paradoxically, on Linux, setting the transparency mode to opaque will
-    // give us proper transparency for composited popups. The shape-mask-based
-    // pseudo-transparency that we use otherwise will render transparent areas
-    // as opaque black when compositing is enabled.
-    // See bug 630346.
-    mode = eTransparencyOpaque;
-  }
-#endif
-
   nsIContent* parentContent = GetContent()->GetParent();
   nsAtom *tag = nullptr;
   if (parentContent && parentContent->IsXULElement())
     tag = parentContent->NodeInfo()->NameAtom();
   widgetData.mHasRemoteContent = remote;
   widgetData.mSupportTranslucency = mode == eTransparencyTransparent;
   widgetData.mDropShadow = !(mode == eTransparencyTransparent || tag == nsGkAtoms::menulist);
   widgetData.mPopupLevel = PopupLevel(widgetData.mNoAutoHide);