Bug 1477793 - Show hidden audio tabs after Hidden Tabs r?dao draft
authorMark Striemer <mstriemer@mozilla.com>
Mon, 23 Jul 2018 14:16:37 -0500
changeset 823569 a97e0a24d9956ea7dae570e2ab2b945993cdb87d
parent 823568 5236d5fadfa0b8ed7e446cb679a0ef4c998a8614
push id117726
push userbmo:mstriemer@mozilla.com
push dateFri, 27 Jul 2018 16:23:35 +0000
reviewersdao
bugs1477793
milestone63.0a1
Bug 1477793 - Show hidden audio tabs after Hidden Tabs r?dao MozReview-Commit-ID: Ce9PLLx3UnB
browser/base/content/browser-allTabsMenu.js
--- a/browser/base/content/browser-allTabsMenu.js
+++ b/browser/base/content/browser-allTabsMenu.js
@@ -29,44 +29,44 @@ var gTabsPanel = {
     this._initializedElements = true;
   },
 
   init() {
     if (this._initialized) return;
 
     this.initElements();
 
-    let hiddenTabsMenuButton = document.getElementById("allTabsMenu-hiddenTabsButton");
-    let hiddenTabsSeparator = document.getElementById("allTabsMenu-hiddenTabsSeparator");
     this.hiddenAudioTabsPopup = new TabsPanel({
       view: this.allTabsView,
-      insertBefore: hiddenTabsSeparator,
+      insertBefore: document.getElementById("allTabsMenu-tabsSeparator"),
       filterFn: (tab) => tab.hidden && tab.soundPlaying,
     });
     this.allTabsPanel = new TabsPanel({
       view: this.allTabsView,
       containerNode: this.allTabsViewTabs,
       filterFn: (tab) => !tab.pinned && !tab.hidden,
     });
 
-    let containerTabsButton = document.getElementById("allTabsMenu-containerTabsButton");
-    let containerTabsSeparator = document.getElementById("allTabsMenu-containerTabsSeparator");
     this.allTabsView.addEventListener("ViewShowing", (e) => {
       PanelUI._ensureShortcutsShown(this.allTabsView);
       e.target.querySelector(".undo-close-tab").disabled =
           SessionStore.getClosedTabCount(window) == 0;
 
       let containersEnabled = Services.prefs.getBoolPref("privacy.userContext.enabled")
                                 && !PrivateBrowsingUtils.isWindowPrivate(window);
-      containerTabsButton.hidden = !containersEnabled;
-      containerTabsSeparator.hidden = !containersEnabled;
+      document.getElementById("allTabsMenu-containerTabsButton")
+        .hidden = !containersEnabled;
+      document.getElementById("allTabsMenu-containerTabsSeparator")
+        .hidden = !containersEnabled;
 
       let hasHiddenTabs = gBrowser.visibleTabs.length < gBrowser.tabs.length;
-      hiddenTabsMenuButton.hidden = !hasHiddenTabs;
-      hiddenTabsSeparator.hidden = !hasHiddenTabs;
+      document.getElementById("allTabsMenu-hiddenTabsButton")
+        .hidden = !hasHiddenTabs;
+      document.getElementById("allTabsMenu-hiddenTabsSeparator")
+        .hidden = !hasHiddenTabs;
     });
 
     this.allTabsView.addEventListener("ViewShown", (e) => {
       let selectedRow = this.allTabsView.querySelector(".all-tabs-item[selected]");
       selectedRow.scrollIntoView({block: "center"});
     });
 
     let containerTabsMenuSeparator = this.containerTabsView.querySelector("toolbarseparator");