Bug 1476204 - Replace duplicate #error-text with .page-error. r=jaws
MozReview-Commit-ID: 2FOx9dpTpAs
--- a/browser/components/payments/res/containers/payment-dialog.js
+++ b/browser/components/payments/res/containers/payment-dialog.js
@@ -48,17 +48,17 @@ export default class PaymentDialog exten
this._shippingAddressPicker = contents.querySelector("address-picker.shipping-related");
this._shippingRelatedEls = contents.querySelectorAll(".shipping-related");
this._payerRelatedEls = contents.querySelectorAll(".payer-related");
this._payerAddressPicker = contents.querySelector("address-picker.payer-related");
this._header = contents.querySelector("header");
- this._errorText = contents.querySelector("#error-text");
+ this._errorText = contents.querySelector("#payment-summary .page-error");
this._disabledOverlay = contents.getElementById("disabled-overlay");
this.appendChild(contents);
super.connectedCallback();
}
--- a/browser/components/payments/res/paymentRequest.css
+++ b/browser/components/payments/res/paymentRequest.css
@@ -86,20 +86,16 @@ payment-dialog > header {
align-items: center;
background-color: #eaeaee;
display: flex;
/* from visual spec: */
padding-top: 20px;
padding-bottom: 18px;
}
-#error-text {
- text-align: center;
-}
-
#order-details-overlay {
background-color: var(--in-content-page-background);
overflow: auto;
position: absolute;
top: 0;
right: 0;
bottom: 0;
left: 0;
--- a/browser/components/payments/res/paymentRequest.xhtml
+++ b/browser/components/payments/res/paymentRequest.xhtml
@@ -101,17 +101,17 @@
<div id="top-buttons" hidden="hidden">
<button id="view-all" class="closed">&viewAllItems;</button>
</div>
</header>
<div id="main-container">
<payment-request-page id="payment-summary">
<div class="page-body">
- <div id="error-text"></div>
+ <div class="page-error" aria-live="polite"></div>
<address-picker class="shipping-related"
data-add-link-label="&address.addLink.label;"
data-edit-link-label="&address.editLink.label;"
data-shipping-address-label="&shippingAddressLabel;"
data-delivery-address-label="&deliveryAddressLabel;"
data-pickup-address-label="&pickupAddressLabel;"
selected-state-key="selectedShippingAddress"></address-picker>
@@ -123,17 +123,16 @@
data-edit-link-label="&basicCard.editLink.label;"
label="&paymentMethodsLabel;">
</payment-method-picker>
<address-picker class="payer-related"
label="&payerLabel;"
data-add-link-label="&payer.addLink.label;"
data-edit-link-label="&payer.editLink.label;"
selected-state-key="selectedPayerAddress"></address-picker>
- <div id="error-text"></div>
</div>
<footer>
<button id="cancel">&cancelPaymentButton.label;</button>
<button id="pay"
class="primary"
data-label="&approvePaymentButton.label;"
data-processing-label="&processingPaymentButton.label;"
--- a/browser/components/payments/test/browser/browser_shippingaddresschange_error.js
+++ b/browser/components/payments/test/browser/browser_shippingaddresschange_error.js
@@ -32,17 +32,17 @@ add_task(async function test_show_error_
await spawnPaymentDialogTask(frame, PTU.DialogContentTasks.selectShippingOptionById, "1");
info("awaiting the shippingoptionchange event");
await ContentTask.spawn(browser, {
eventName: "shippingoptionchange",
}, PTU.ContentTasks.awaitPaymentRequestEventPromise);
await spawnPaymentDialogTask(frame, expectedText => {
- let errorText = content.document.querySelector("#error-text");
+ let errorText = content.document.querySelector("#payment-summary .page-error");
is(errorText.textContent, expectedText, "Error text should be on dialog");
ok(content.isVisible(errorText), "Error text should be visible");
}, PTU.Details.genericShippingError.error);
info("setting up the event handler for shippingaddresschange");
await ContentTask.spawn(browser, {
eventName: "shippingaddresschange",
details: Object.assign({},
@@ -54,17 +54,17 @@ add_task(async function test_show_error_
await selectPaymentDialogShippingAddressByCountry(frame, "DE");
info("awaiting the shippingaddresschange event");
await ContentTask.spawn(browser, {
eventName: "shippingaddresschange",
}, PTU.ContentTasks.awaitPaymentRequestEventPromise);
await spawnPaymentDialogTask(frame, () => {
- let errorText = content.document.querySelector("#error-text");
+ let errorText = content.document.querySelector("#payment-summary .page-error");
is(errorText.textContent, "", "Error text should not be on dialog");
ok(content.isHidden(errorText), "Error text should not be visible");
});
info("clicking cancel");
spawnPaymentDialogTask(frame, PTU.DialogContentTasks.manuallyClickCancel);
await BrowserTestUtils.waitForCondition(() => win.closed, "dialog should be closed");
@@ -107,17 +107,17 @@ add_task(async function test_show_field_
let {
PaymentTestUtils: PTU,
} = ChromeUtils.import("resource://testing-common/PaymentTestUtils.jsm", {});
await PTU.DialogContentUtils.waitForState(content, (state) => {
return Object.keys(state.request.paymentDetails.shippingAddressErrors).length;
}, "Check that there are shippingAddressErrors");
- is(content.document.querySelector("#error-text").textContent,
+ is(content.document.querySelector("#payment-summary .page-error").textContent,
PTU.Details.fieldSpecificErrors.error,
"Error text should be present on dialog");
info("click the Edit link");
content.document.querySelector("address-picker .edit-link").click();
await PTU.DialogContentUtils.waitForState(content, (state) => {
return state.page.id == "address-page" && state["address-page"].guid;
@@ -160,17 +160,17 @@ add_task(async function test_show_field_
await PTU.DialogContentUtils.waitForState(content, (state) => {
return state.page.id == "payment-summary";
}, "Check we're back on summary view");
await PTU.DialogContentUtils.waitForState(content, (state) => {
return !Object.keys(state.request.paymentDetails.shippingAddressErrors).length;
}, "Check that there are no more shippingAddressErrors");
- is(content.document.querySelector("#error-text").textContent,
+ is(content.document.querySelector("#payment-summary .page-error").textContent,
"", "Error text should not be present on dialog");
info("click the Edit link again");
content.document.querySelector("address-picker .edit-link").click();
await PTU.DialogContentUtils.waitForState(content, (state) => {
return state.page.id == "address-page" && state["address-page"].guid;
}, "Check edit page state");