Bug 1475916 - Use em instead of px for list heights to keep font scaling into account. r=bgrins draft
authorPaolo Amadini <paolo.mozmail@amadzone.org>
Mon, 23 Jul 2018 10:07:38 +0100
changeset 821433 12d348d94c6fd582831398ed884ded29f1f3be6a
parent 821432 f56f7bdf1a6aaf8b71c07edd2d671f0d12970a3e
push id117091
push userpaolo.mozmail@amadzone.org
push dateMon, 23 Jul 2018 09:08:29 +0000
reviewersbgrins
bugs1475916
milestone63.0a1
Bug 1475916 - Use em instead of px for list heights to keep font scaling into account. r=bgrins MozReview-Commit-ID: FDMwrHg27ad
browser/components/preferences/languages.xul
browser/themes/shared/incontentprefs/preferences.inc.css
toolkit/components/prompts/content/selectDialog.xul
toolkit/profile/content/profileSelection.xul
toolkit/themes/osx/mozapps/profile/profileSelection.css
toolkit/themes/windows/mozapps/profile/profileSelection.css
--- a/browser/components/preferences/languages.xul
+++ b/browser/components/preferences/languages.xul
@@ -44,17 +44,17 @@
               onsynctopreference="return gLanguagesDialog.writeSpoofEnglish();"/>
     <grid flex="1">
       <columns>
         <column flex="1"/>
         <column/>
       </columns>
       <rows>
         <row flex="1">
-          <richlistbox id="activeLanguages" flex="1" height="200"
+          <richlistbox id="activeLanguages" flex="1"
                        seltype="multiple"
                        onselect="gLanguagesDialog.onLanguageSelect();"/>
           <vbox>
             <button id="up" class="up" oncommand="gLanguagesDialog.moveUp();" disabled="true"
                     data-l10n-id="languages-customize-moveup"
                     preference="pref.browser.language.disable_button.up"/>
             <button id="down" class="down" oncommand="gLanguagesDialog.moveDown();" disabled="true"
                     data-l10n-id="languages-customize-movedown"
--- a/browser/themes/shared/incontentprefs/preferences.inc.css
+++ b/browser/themes/shared/incontentprefs/preferences.inc.css
@@ -204,16 +204,20 @@ button > hbox > label {
   width: 30px;
   margin-inline-start: 5px;
 }
 
 #getStarted {
   font-size: 90%;
 }
 
+#activeLanguages {
+  height: 16em;
+}
+
 #activeLanguages > richlistitem {
   padding: 0.3em;
 }
 
 #downloadFolder {
   margin-inline-start: 0;
   padding-inline-start: 30px;
   background-repeat: no-repeat;
--- a/toolkit/components/prompts/content/selectDialog.xul
+++ b/toolkit/components/prompts/content/selectDialog.xul
@@ -11,12 +11,12 @@
       onload="dialogOnLoad()"
       ondialogaccept="return dialogOK();">
 
   <script type="application/javascript" src="chrome://global/content/selectDialog.js" />
   <keyset id="dialogKeys"/>
   <vbox style="width: 24em;margin: 5px;">
     <label id="info.txt"/>
     <vbox>
-      <richlistbox id="list" class="theme-listbox" height="80"/>
+      <richlistbox id="list" class="theme-listbox" style="height: 8em;"/>
     </vbox>
   </vbox>
 </dialog>
--- a/toolkit/profile/content/profileSelection.xul
+++ b/toolkit/profile/content/profileSelection.xul
@@ -52,17 +52,17 @@
               accesskey="&renameButton.accesskey;" oncommand="RenameProfile();"/>
       <button id="delbutton" label="&deleteButton.label;"
               accesskey="&deleteButton.accesskey;" oncommand="ConfirmDelete();"/>
     </vbox>
 
     <separator flex="1"/>
 
     <vbox flex="1">
-      <richlistbox id="profiles" class="theme-listbox" height="100" seltype="single"
+      <richlistbox id="profiles" class="theme-listbox" seltype="single"
                    ondblclick="onProfilesDblClick(event)"
                    onkeypress="onProfilesKey(event);">
       </richlistbox>
 
       <!-- Bug 257777 -->
       <checkbox id="offlineState" label="&offlineState.label;" accesskey="&offlineState.accesskey;"/>
 
       <checkbox id="autoSelectLastProfile" label="&useSelected.label;"
--- a/toolkit/themes/osx/mozapps/profile/profileSelection.css
+++ b/toolkit/themes/osx/mozapps/profile/profileSelection.css
@@ -9,8 +9,12 @@
 
 box#managebuttons > button {
   min-width: 8em;
 }
 
 #managebuttons {
   padding-top: 1em;
 }
+
+#profiles {
+  height: 12em;
+}
--- a/toolkit/themes/windows/mozapps/profile/profileSelection.css
+++ b/toolkit/themes/windows/mozapps/profile/profileSelection.css
@@ -9,8 +9,12 @@
 
 box#managebuttons > button {
   min-width: 8em;
 }
 
 #managebuttons {
   padding-top: 1em;
 }
+
+#profiles {
+  height: 12em;
+}